Leftover ObservableObject XML docs fix, minor tweaks #3505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
documentation 📃
improvements ✨
.NET
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
michael-hawker
approved these changes
Sep 28, 2020
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leftover from #3429
PR Type
What kind of change does this PR introduce?
Changes
SetPropertymethodSetProperty<TModel, T>(T, T, TModel, Action<TModel, T>, string?)had an uncostrained type argumentTModel. This would've resulted in potential bugs in case the model was a value type, as the instance passed as input to the callback would've been passed by copy, hence the update would've been lost (only the local copy in the callback would've been updated). I've add awhere TModel : classconstraint to prevent this from happening. I wouldn't expect users to actually try to use that with value types, but anyway the signature is more correct and less error prone now 😄PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templatesTests for the changes have been added (for bug fixes / features) (if applicable)Header has been added to all new source files (run build/UpdateHeaders.bat)