Add basic SwitchPresenter Sample #3789

michael-hawker · 2021-02-25T20:29:22Z

Also Fixes #3671, and related to #1908

Adds a basic sample for SwitchPresenter to the sample app. Would like to do a more advanced one still though. This also fixes a small bug in the case selection logic.

Any suggestions for sample scenarios where we could switch off a strong type like an enum or some other type would be appreciated. 🙂

PR Type

What kind of change does this PR introduce?

Bugfix

Sample app changes

What is the current behavior?

Would crash if no default case provided and no matching case available.

(And no sample.)

What is the new behavior?

Control goes back to presenting nothing if no match or default is available.

Sample!

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs
Pull Request has been submitted to the documentation repository instructions. Link:
Sample in sample app has been added / updated (for bug fixes / features)
- Icon has been created (if new sample) following the Thumbnail Style Guide and templates
New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
Tests for the changes have been added (for bug fixes / features) (if applicable)
Header has been added to all new source files (run build/UpdateHeaders.bat)
Contains NO breaking changes

TO DO

Add an Advanced scenario to the page using TargetType
Address [Feature] Provide a Type MarkupExtension #3784 as well? (Think un-needed for now?) App can always do this if needed.
Remove listening for Child Value binding changes as complicates the control.

ghost · 2021-02-25T20:29:25Z

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Microsoft.Toolkit.Uwp.UI.Controls.Primitives/SwitchPresenter/SwitchPresenter.cs

Fix name of TargetType DependencyProperty Add better Enum string support

…ection or case values Can't think of scenarios where this was actually useful and added a lot of complexity. Removing it for now for the core value the control provides and simplifies the structure. Samples from Sample App continue to work as expected.

michael-hawker · 2021-03-04T20:38:48Z

@chingucoding thanks for taking a look, I've made updates based on our discussions and simplified the logic as you suggested.

@RosarioPulella or @Kyaa-dost want to take a quick look? This is ready to go now! 🎉🎉🎉

ghost · 2021-03-04T20:38:56Z

Hello @michael-hawker!

Because this pull request has the auto merge :zap: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Primitives/SwitchPresenter.bind

Sergio0694

Couple minor questions, but looks good and works great! 🎉

Sergio0694 · 2021-03-04T21:57:42Z

Microsoft.Toolkit.Uwp.UI.Controls.Primitives/SwitchPresenter/CaseCollection.cs

        /// <summary>
        /// Initializes a new instance of the <see cref="CaseCollection"/> class.
        /// </summary>
        public CaseCollection()
        {
        }


Nit: this could safely be removed in theory, right?

Sergio0694 · 2021-03-04T21:58:00Z

Microsoft.Toolkit.Uwp.UI.Controls.Primitives/SwitchPresenter/CaseCollection.cs

    /// An collection of <see cref="Case"/> to help with XAML interop.
    /// </summary>
-    public class CaseCollection : IList<Case>, IEnumerable<Case> // TODO: Do we need this or can we use an ObservableCollection directly??? (Or is it useful to have it manage the registration of the child events?)
+    public class CaseCollection : DependencyObjectCollection


Is this not sealed on purpose?

Sergio0694 · 2021-03-04T21:58:53Z

Microsoft.Toolkit.Uwp.UI.Controls.Primitives/SwitchPresenter/SwitchPresenter.cs

+                static object ThrowExceptionForKeyNotFound()
+                {
+                    throw new InvalidOperationException("The requested enum value was not present in the provided type.");
+                }
+
+                return ThrowExceptionForKeyNotFound();


Ha, nice! 😄

marcelwgn · 2021-03-04T21:39:30Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/EnumValuesExtension/Animal.cs

        Cat,
        Dog,
        Bunny,
+        Llama,


Most important change in this PR :P

marcelwgn · 2021-03-04T21:39:53Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Primitives/SwitchPresenter.bind

+                   ui:TextBoxExtensions.Regex="^[a-zA-Z]{6}$"
+                   Header="Confirmation code"
+                   PlaceholderText="6 letters" />
+          <TextBlock Visibility="{Binding (ui:TextBoxExtensions.IsValid), ElementName=ConfirmationCodeValidator}">Thanks for entering a valid code!</TextBlock>


nit: use Text property for fast path rendering

marcelwgn · 2021-03-04T21:40:02Z

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Primitives/SwitchPresenter.bind

+                   ui:TextBoxExtensions.Regex="(^\d{10}$)|(^\d{13}$)"
+                   Header="E-ticket number"
+                   PlaceholderText="10 or 13 numbers" />
+          <TextBlock Visibility="{Binding (ui:TextBoxExtensions.IsValid), ElementName=TicketValidator}">Thanks for entering a valid code!</TextBlock>


nit: same here

michael-hawker added this to the 7.0 milestone Feb 25, 2021

ghost requested review from Kyaa-dost, Rosuavio and azchohfi February 25, 2021 20:29

michael-hawker added controls 🎛️ sample app 🖼 labels Feb 25, 2021

ghost added the bug 🐛 An unexpected issue that highlights incorrect behavior label Feb 25, 2021

marcelwgn reviewed Feb 25, 2021

View reviewed changes

Microsoft.Toolkit.Uwp.UI.Controls.Primitives/SwitchPresenter/SwitchPresenter.cs Outdated Show resolved Hide resolved

michael-hawker added 6 commits March 4, 2021 11:25

Fixes CommunityToolkit#3671 - No Case found scenario

9bbe69c

Add basic SwitchPresenter sample to Sample App

2506faa

Remove complex property from SwitchPresenter

c63e695

Fix name of TargetType DependencyProperty Add better Enum string support

Remove duplicate style from WrapPanel sample

332fd2c

Clean-up sample and better separate the two examples

08bbe58

michael-hawker force-pushed the switchpresenter-sample branch from 41225e1 to 2e3ccec Compare March 4, 2021 20:37

michael-hawker marked this pull request as ready for review March 4, 2021 20:37

michael-hawker added the reviewers wanted ✋ label Mar 4, 2021

michael-hawker added the auto merge ⚡ label Mar 4, 2021

marcelwgn reviewed Mar 4, 2021

View reviewed changes

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Primitives/SwitchPresenter.bind Show resolved Hide resolved

🦙 Add more 🦙

bb961a4

Sergio0694 reviewed Mar 4, 2021

View reviewed changes

Microsoft.Toolkit.Uwp.SampleApp/SamplePages/Primitives/SwitchPresenter.bind Show resolved Hide resolved

Kyaa-dost approved these changes Mar 4, 2021

View reviewed changes

Sergio0694 approved these changes Mar 4, 2021

View reviewed changes

marcelwgn approved these changes Mar 4, 2021

View reviewed changes

ghost merged commit 0feca9c into CommunityToolkit:master Mar 4, 2021

michael-hawker mentioned this pull request Mar 5, 2021

Add docs for SwitchPresenter MicrosoftDocs/WindowsCommunityToolkitDocs#458

Merged

5 tasks

Kyaa-dost added the doc-provided ✔️ label Mar 8, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic SwitchPresenter Sample #3789

Add basic SwitchPresenter Sample #3789

Uh oh!

michael-hawker commented Feb 25, 2021 •

edited

Loading

Uh oh!

ghost commented Feb 25, 2021

Uh oh!

Uh oh!

michael-hawker commented Mar 4, 2021

Uh oh!

ghost commented Mar 4, 2021

Uh oh!

Uh oh!

Uh oh!

Sergio0694 left a comment

Uh oh!

Sergio0694 Mar 4, 2021

Uh oh!

Sergio0694 Mar 4, 2021

Uh oh!

Sergio0694 Mar 4, 2021

Uh oh!

marcelwgn Mar 4, 2021

Uh oh!

marcelwgn Mar 4, 2021

Uh oh!

marcelwgn Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Add basic SwitchPresenter Sample #3789

Add basic SwitchPresenter Sample #3789

Uh oh!

Conversation

michael-hawker commented Feb 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Also Fixes #3671, and related to #1908

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

TO DO

Uh oh!

ghost commented Feb 25, 2021

Uh oh!

Uh oh!

michael-hawker commented Mar 4, 2021

Uh oh!

ghost commented Mar 4, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Uh oh!

Uh oh!

Uh oh!

Sergio0694 left a comment

Choose a reason for hiding this comment

Uh oh!

Sergio0694 Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

Sergio0694 Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

Sergio0694 Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

marcelwgn Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

marcelwgn Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

marcelwgn Mar 4, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

michael-hawker commented Feb 25, 2021 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.