Add [field:] and [property:] support for [RelayCommand] methods#630
Merged
Sergio0694 merged 6 commits intomainfrom Mar 9, 2023
Merged
Add [field:] and [property:] support for [RelayCommand] methods#630Sergio0694 merged 6 commits intomainfrom
Sergio0694 merged 6 commits intomainfrom
Conversation
Sergio0694
added
feature 💡
Youssef1313
reviewed
Mar 8, 2023
...iagnostics/Suppressors/RelayCommandAttributeWithFieldOrPropertyTargetDiagnosticSuppressor.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Mar 8, 2023
src/CommunityToolkit.Mvvm.SourceGenerators/Extensions/SymbolInfoExtensions.cs
Outdated
Show resolved
Hide resolved
Youssef1313
approved these changes
Mar 8, 2023
Sergio0694
force-pushed
the
dev/relay-command-attribute-forwarding
branch
from
60cb7bf to
13ce990
Compare
Arlodotexe
approved these changes
Mar 9, 2023
Member
Arlodotexe
left a comment
Arlodotexe
left a comment
There was a problem hiding this comment.
No obvious issues. Looks good! 🚀
delete-merged-branch
bot
deleted the
dev/relay-command-attribute-forwarding
branch
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #599
@Youssef1313 do you mind also taking a quick look whenever you have time? Thank you! 😄
PR Checklist