Improve ImmutableArrayBuilder<T> type in MVVM Toolkit generators#701
Merged
Sergio0694 merged 3 commits intomainfrom May 16, 2023
Merged
Improve ImmutableArrayBuilder<T> type in MVVM Toolkit generators#701Sergio0694 merged 3 commits intomainfrom
Sergio0694 merged 3 commits intomainfrom
Conversation
Member
Author
|
Hey @Youssef1313, would you mind taking a quick look when you have a minute? Thank you! 🙂 |
161519c to
f87610a
Compare
Youssef1313
reviewed
May 16, 2023
src/CommunityToolkit.Mvvm.SourceGenerators/Helpers/ImmutableArrayBuilder{T}.cs
Show resolved
Hide resolved
Youssef1313
reviewed
May 16, 2023
src/CommunityToolkit.Mvvm.SourceGenerators/Helpers/ImmutableArrayBuilder{T}.cs
Show resolved
Hide resolved
Sergio0694
added a commit
to CommunityToolkit/Labs-Windows
that referenced
this pull request
May 31, 2023
This was referenced Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR includes a couple tweaks to
ImmutableArrayBuilder<T>:ObjectPool<T>use, and just usesArrayPool<T>. This means we can now also benefit from the automatic trimming thatArrayPool<T>implements if there is high GC pressure. Also, we're no longer reinventing the wheel here.ref struct, since we're never meant to pass this outside or box it.PR Checklist