Remove unnecessary temporary array allocation#719
Merged
Sergio0694 merged 2 commits intomainfrom Jun 21, 2023
Merged
Conversation
Member
Author
|
Hey @Youssef1313, want to take a quick lock when you have a minute? This one is very smol 😄 |
Youssef1313
reviewed
Jun 20, 2023
...CommunityToolkit.Mvvm.SourceGenerators/ComponentModel/ObservablePropertyGenerator.Execute.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Jun 20, 2023
src/CommunityToolkit.Mvvm.SourceGenerators/Helpers/ImmutableArrayBuilder{T}.cs
Show resolved
Hide resolved
Member
Author
|
@Youssef1313 I assume you have no other concerns with this one, so good to go? 😄 |
This was referenced Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an API to enumerate items in an array builder without allocating a whole array.
It also uses this API when creating a
BlockSyntax, to avoid wasting an array just to enumerate items.The returned enumerable is readonly, ensuring mutations must go through the actual builder.
PR Checklist