Skip to content

Fix IBufferWriterExtensions Write for unmanaged types#799

Merged
Sergio0694 merged 1 commit intoCommunityToolkit:mainfrom
pziezio:fix-ibufferwriter-span-size
Aug 20, 2024
Merged

Fix IBufferWriterExtensions Write for unmanaged types#799
Sergio0694 merged 1 commit intoCommunityToolkit:mainfrom
pziezio:fix-ibufferwriter-span-size

Conversation

@pziezio
Copy link
Contributor

@pziezio pziezio commented Nov 21, 2023

Closes #798

Fixes extension method and adds a test to ensure a correct bahavior.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 force-pushed the fix-ibufferwriter-span-size branch from cb35444 to 278a64d Compare August 20, 2024 16:55
@Sergio0694 Sergio0694 force-pushed the fix-ibufferwriter-span-size branch from 278a64d to 8de7190 Compare August 20, 2024 17:10
Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙂

@Sergio0694 Sergio0694 merged commit 5670be1 into CommunityToolkit:main Aug 20, 2024
@pziezio pziezio deleted the fix-ibufferwriter-span-size branch August 20, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in IBufferWriterExtension Write for unmanaged types

2 participants