start_time should be initialized at the end of EventHandler's constructor

[Asperamanca]

EventHandler(int line = __builtin_LINE(), const char* filename = __builtin_FILE(), const char* function = __builtin_FUNCTION(), std::chrono::high_resolution_clock::time_point start_time = std::chrono::high_resolution_clock::now()) : line(line)

{
	this->start_time = start_time;
	previous_store_clear_cnt = store::store_clear_cnt;
	this->filename = filename;
	this->function = function;
	while (store::write_events_locked) {}

	register_event();
}

start_time should be initialized at the end of the constructor (after register_event) in order to exclude time spent in bookkeeping from measured time.
Thanks to Ben Craig for pointing this out to me while discussing my benchmark results.

[Asperamanca]

For functions that are very fast, the difference is noticable (e.g. 538.10 mcs instead of 624.10 mcs on 2000 iterations)

[Compaile]

yes, totally agreed

thanks for spotting that silly oversight.
Will fix later today

[Asperamanca]

If I read your fix right, it won't work. It still takes the timestamp of where the function is entered. std::chrono::high_resolution_clock::now() cannot happen as part of the parameter list, it must happen at the end of the constructor block.
Is the parameter even necessary? Are there use cases where you pass the start_time from the outside?

[Compaile]

oh yeah. never submit code after long day of work :D
originally i wanted to let the user have this option in case they use it for custom events. But i guess the benefits of having it a bit more precise outweighs the possible other usecase by a lot . And when the need would ever come back we can always add a second constructor for that i guess

[Asperamanca]

You could always add an overload to the constructor if you later wish to add the option of passing a time point.

[Compaile]

exactly , just edited that at the literally same moment
thanks for pointing out the bug