Fix warnings to allow using the header on pedantic projects#9
Merged
Compaile merged 1 commit intoCompaile:mainfrom Nov 12, 2024
Merged
Fix warnings to allow using the header on pedantic projects#9Compaile merged 1 commit intoCompaile:mainfrom
Compaile merged 1 commit intoCompaile:mainfrom
Conversation
Some projects have strict requirements regarding warnings. Let's have an option to enable pedantic warnings and address them to allow those projects to use the header without having to disable them manually. e.g. for ClickHouse #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wall" #pragma clang diagnostic ignored "-Wextra" #pragma clang diagnostic ignored "-Weverything" #pragma clang diagnostic ignored "-Wpedantic" #define CTRACK_DISABLE_EXECUTION_POLICY 1 #include "ctrack.hpp" #pragma clang diagnostic pop
Owner
|
Good point, will review shortly |
Owner
|
Thanks for the pr |
Contributor
Author
|
Thank you for your work on this lightweight and very easy to integrate and use library. Cheers 🍻 |
Compaile
added a commit
that referenced
this pull request
May 28, 2025
Fix warnings to allow using the header on pedantic projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some projects have strict requirements regarding warnings. Let's have an option to enable pedantic warnings and address them to allow those projects to use the header without having to disable them manually.
e.g. for ClickHouse
I've disabled some warnings compared to the ones we use at ClickHouse because they were too many and could be a style decision:
shadow-field-in-constructorandnewline-eof.