sprockets 3 compatibility#262
Closed
vojtad wants to merge 3 commits intoCompass:masterfrom
vojtad:fix-sprockets-3
Closed
sprockets 3 compatibility#262vojtad wants to merge 3 commits intoCompass:masterfrom vojtad:fix-sprockets-3
vojtad wants to merge 3 commits intoCompass:masterfrom
vojtad:fix-sprockets-3
Conversation
When config.assets.compile is false sprockets does not set ::Rails.application.assets. Use ::Rails.application.config.assets instead.
Use ::Rails.application.assets_manifest instead of ::Rails.application.assets when config.assets.compile is not set.
|
|
||
| def sprockets | ||
| @sprockets ||= ::Rails.application.assets | ||
| @sprockets ||= ::Rails.application.assets || ::Rails.application.config.assets |
There was a problem hiding this comment.
Rails.application.assets and Rails.application.config.assets are completely different things. They are not mutually interchangeable.
Contributor
Author
There was a problem hiding this comment.
You are right, however, they both respond to paths. Nevermind, I think @timhaines took a better approach at fixing this issue in #263.
Member
|
I merged #263 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sprockets 3 does not set ::Rails.application.assets when ::Rails.application.config.assets.compile is false. I have changed code to return ::Rails.application.config.assets instead. It returns correct assets paths.
I have also updated patched image_path_for_size for compass, it should work even with disabled config.assets.compile now.