Skip to content

Remove unused parameter missing_file_pass from rules and docs#12715

Merged
Mab879 merged 1 commit intoComplianceAsCode:masterfrom
mpurg:fix_missing_file_pass
Dec 13, 2024
Merged

Remove unused parameter missing_file_pass from rules and docs#12715
Mab879 merged 1 commit intoComplianceAsCode:masterfrom
mpurg:fix_missing_file_pass

Conversation

@mpurg
Copy link
Copy Markdown
Contributor

@mpurg mpurg commented Dec 13, 2024

Description:

  • Remove unused parameter missing_file_pass from rules and docs

Rationale:

The missing_file_pass parameter has had no function since it was
removed from templates file_owner, file_groupowner and file_permissions in ComplianceAsCode#8456.
The parameter references were removed from the rules, documentation, and
template preprocessing scripts to avoid confusion.
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 13, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 13, 2024
@github-actions
Copy link
Copy Markdown

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 377ffdc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Dec 13, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Dec 13, 2024
Copy link
Copy Markdown
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Mab879
Copy link
Copy Markdown
Member

Mab879 commented Dec 13, 2024

Waving Automatus tests as some rules cannot be tested in a container.

@Mab879 Mab879 merged commit 0b16615 into ComplianceAsCode:master Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Used by openshift-ci bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants