Skip to content

add variable to network providers and add cilium per default#13346

Merged
yuumasato merged 1 commit intoComplianceAsCode:masterfrom
sluetze:var-networkpolicy
Mar 6, 2026
Merged

add variable to network providers and add cilium per default#13346
yuumasato merged 1 commit intoComplianceAsCode:masterfrom
sluetze:var-networkpolicy

Conversation

@sluetze
Copy link
Copy Markdown
Contributor

@sluetze sluetze commented Apr 16, 2025

Description:

This PR adds Cilium to the default regex which is checked to see if the CNI Plugin used provides support for network-policies. This PR also makes this value configurable

Rationale:

Cilium does support Network Policies in different styles: https://docs.cilium.io/en/latest/security/policy/index.html
Also making it configurable, allows people to define their own values in the variable without changing sourcecode

Review Hints:

I did not have a Cilium Cluster at Hand. Therefore I checked with default CIS Profile

and a tailored profile which changes the regex and creates a false result in my environment (as expected)

apiVersion: compliance.openshift.io/v1alpha1
kind: TailoredProfile
metadata:
  name: test-tailoredprofile-ciliumonly
spec:
  description: Example of a tailoredProfile that extends OCP4 FedRAMP Moderate
  extends: ocp4-cis
  setValues:
    - name: ocp4-var-configure-network-policies-regex
      rationale: testing Cilium
      value: Cilium
  title: My little profile

@openshift-ci openshift-ci Bot added the needs-ok-to-test Used by openshift-ci bot. label Apr 16, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 16, 2025

Hi @sluetze. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 0884790 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny added the OpenShift OpenShift product related. label Apr 17, 2025
@github-actions
Copy link
Copy Markdown

ATEX Test Results

Test artifacts have been submitted to Testing Farm.

Results: View Test Results
Workflow Run: View Workflow Details

This comment was automatically generated by the ATEX workflow.

@yuumasato yuumasato self-assigned this Feb 11, 2026
@yuumasato yuumasato added this to the 0.1.81 milestone Mar 5, 2026
@yuumasato
Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Mar 5, 2026
@yuumasato yuumasato added needs-ok-to-test Used by openshift-ci bot. CIS CIS Benchmark related. and removed ok-to-test Used by openshift-ci bot. labels Mar 5, 2026
Copy link
Copy Markdown
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato yuumasato merged commit 256da96 into ComplianceAsCode:master Mar 6, 2026
143 of 145 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. OpenShift OpenShift product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants