OCPBUGS-55140: Enhance RHCOS checks to include CoreOS variant for 4.19#13369
Merged
rhmdnd merged 1 commit intoComplianceAsCode:masterfrom Apr 22, 2025
Merged
OCPBUGS-55140: Enhance RHCOS checks to include CoreOS variant for 4.19#13369rhmdnd merged 1 commit intoComplianceAsCode:masterfrom
rhmdnd merged 1 commit intoComplianceAsCode:masterfrom
Conversation
Contributor
Author
|
/test |
|
@Vincent056: The Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/test e2e-aws-rhcos4-high |
Contributor
Author
|
/test 4.19-e2e-aws-rhcos4-high |
Collaborator
|
@Vincent056 Seems it still returns NOT-APPLICABLE for upstream-rhcos4-moderate profile. Could you please help to check again? Thanks. |
Signed-off-by: Vincent Shen <wenshen@redhat.com>
|
Code Climate has analyzed commit 3327fa3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Collaborator
|
/test e2e-aws-rhcos4-high |
Collaborator
|
Verification pass with content built from PR #13369: |
|
@Vincent056: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Collaborator
|
For 4.19-e2e-aws-rhcos4-high job: |
Collaborator
|
Seems to continue working on 4.16, which is good. |
rhmdnd
approved these changes
Apr 22, 2025
Collaborator
rhmdnd
left a comment
rhmdnd
left a comment
There was a problem hiding this comment.
/lgtm
Nearly all the differences in the assertions between 4.19 and 4.18 are related to the ARM rules, where we set them to or NOT-APPLICABLE.
Otherwise, it looks like the majority of what's in the assertion file generated by the suite it the same as what is in the assertion file for 4.18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OCP 4.19+ we are using RHEL bootimages, we should include that to rhcos platform CPE.
Related Changes: openshift/installer#9392