Skip to content

Fix help text formatting in build_ds_container.py#14260

Merged
jan-cerny merged 1 commit intoComplianceAsCode:masterfrom
xiaojiey:fix-build
Dec 26, 2025
Merged

Fix help text formatting in build_ds_container.py#14260
jan-cerny merged 1 commit intoComplianceAsCode:masterfrom
xiaojiey:fix-build

Conversation

@xiaojiey
Copy link
Copy Markdown
Collaborator

@xiaojiey xiaojiey commented Dec 24, 2025

Description:

Fix help text formatting in build_ds_container.py. The wrong formate will bring an error when trying to deploy the profiles on a ocp cluster.

Rationale:

without the fix, you will get error below:

$ ./utils/build_ds_container.py -c -p
...
TypeError: can only concatenate tuple (not "str") to tuple
Traceback (most recent call last):
  File "/home/xiyuan/isc/content/./utils/build_ds_container.py", line 46, in <module>
    parser.add_argument(
    ~~~~~~~~~~~~~~~~~~~^
        '-np', '--no-upstream-prefix',
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
        action='store_true',
        ^^^^^^^^^^^^^^^^^^^^
        default=False)
        ^^^^^^^^^^^^^^
  File "/usr/lib64/python3.14/argparse.py", line 1561, in add_argument
    self._check_help(action)

@xiaojiey xiaojiey added the OpenShift OpenShift product related. label Dec 24, 2025
@xiaojiey xiaojiey requested a review from Vincent056 December 24, 2025 09:43
@github-actions
Copy link
Copy Markdown

ATEX Test Results

Test artifacts have been submitted to Testing Farm.

Results: View Test Results
Workflow Run: View Workflow Details

This comment was automatically generated by the ATEX workflow.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 24, 2025

@xiaojiey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-openshift-node-compliance 19794ba link true /test e2e-aws-openshift-node-compliance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jan-cerny jan-cerny added this to the 0.1.80 milestone Dec 26, 2025
@jan-cerny jan-cerny merged commit fcaf3ae into ComplianceAsCode:master Dec 26, 2025
139 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OpenShift OpenShift product related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants