Changed shell command#3328
Merged
mpreisler merged 1 commit intoComplianceAsCode:masterfrom Sep 19, 2018
Merged
Conversation
Changed the shell command per @cmattern-rht . Not all values returned with <code>rpm -Va | grep ^.M </code> have the same number of fields and so the <code>rpm --setperms</code> was failing on those empty values. This will take the last value which is always the path that is needed.
Collaborator
|
Can one of the admins verify this patch? |
Contributor
|
@openscap-ci test this please |
|
The inspection completed: No new issues |
Member
|
Looks great! Thank you for your contribution and welcome! :-). I will check that it works on all supported platforms and then merge. |
Member
|
Tested the code and it works on Fedora 28, RHEL6 and RHEL7. Before this gets merged, could you please also fix |
|
Happy to, busy day today, will try to knock out tonight.
…On Tue, Sep 18, 2018 at 8:15 AM Martin Preisler ***@***.***> wrote:
Tested the code and it works on Fedora 28, RHEL6 and RHEL7.
Before this gets merged, could you please also fix
linux_os/guide/system/software/integrity/software-integrity/rpm_verification/rpm_verify_permissions/bash/shared.sh?
Both are using the same code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3328 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AkyMtyzf1w_lrp6_Yket1yxK0kP0DSENks5ucOPNgaJpZM4WsZsY>
.
--
CHUCK MATTERN
PRINCIPAL SOLUTION ARCHITECT, RHCE
Red Hat
<https://www.redhat.com/>
cmattern@redhat.com T: 678.590.2344
*RED HAT | DIFFERENT FOR THE SAKE OF BETTER TECHNOLOGY*
Find out why every airline, telecom, commercial bank, healthcare and
financial data services company in the Fortune 500 rely on Red Hat,
Trusted | Red Hat <http://www.redhat.com/en/about/trusted>
|
Contributor
Author
|
I'll take care of it today.
Mixer9
…On Tue, Sep 18, 2018, 7:15 AM Martin Preisler ***@***.***> wrote:
Tested the code and it works on Fedora 28, RHEL6 and RHEL7.
Before this gets merged, could you please also fix
linux_os/guide/system/software/integrity/software-integrity/rpm_verification/rpm_verify_permissions/bash/shared.sh?
Both are using the same code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3328 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ah5iv0PmO9eiWPb0M89nso7usQBIv2v3ks5ucOPNgaJpZM4WsZsY>
.
|
Merged
Mixer9
added a commit
to Mixer9/content
that referenced
this pull request
Sep 19, 2018
This change has the same effect as ComplianceAsCode#3328 and potentially could return empty values based on number of field differences, using awk and printing the last field no matter how many fixes this issue.
Merged
Mixer9
added a commit
to Mixer9/content
that referenced
this pull request
Sep 19, 2018
This change has the same effect as ComplianceAsCode#3328 and potentially could return empty values based on number of field differences, using awk and printing the last field no matter how many fixes this issue.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Changed the shell command per @cmattern-rht .
Rationale:
Not all values returned with
rpm -Va | grep ^.Mhave the same number of fields and so therpm --setpermswas failing on those empty values. This will take the last value which is always the path that is needed.