-
Notifications
You must be signed in to change notification settings - Fork 794
Drop deprecated or removed packages in RHEL8 #3632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
yuumasato
wants to merge
6
commits into
ComplianceAsCode:master
from
yuumasato:rhel8_remove_deprecated_packages
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
da2433c
Drop deprecated or removed packages in RHEL8
yuumasato f652cc9
Remove rules not applicable to RHEL8
yuumasato de69cc1
Remove dropped packages rules from RHEL8 profiles
yuumasato af92ef4
Smartcards auth in RHEL8 should be done via sssd
yuumasato 37e698a
Remove smartcard_auth from RHEL8
yuumasato 737a42b
Remove install_smartcard_packages from RHEL8
yuumasato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ libreswan | |
| ntp | ||
| opensc | ||
| openssh-server | ||
| pcsc-lite | ||
| vsftpd | ||
| postfix | ||
| screen | ||
|
|
||
2 changes: 1 addition & 1 deletion
2
linux_os/guide/services/ldap/openldap_server/package_openldap-servers_removed/rule.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
linux_os/guide/services/obsolete/nis/package_ypbind_removed/rule.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
linux_os/guide/services/obsolete/nis/service_ypbind_disabled/rule.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| documentation_complete: true | ||
|
|
||
| prodtype: rhel6,rhel7,rhel8 | ||
| prodtype: rhel6,rhel7 | ||
|
|
||
| title: 'Disable ypbind Service' | ||
|
|
||
|
|
||
2 changes: 1 addition & 1 deletion
2
linux_os/guide/services/obsolete/r_services/package_rsh_removed/rule.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| documentation_complete: true | ||
|
|
||
| prodtype: rhel6,rhel7,rhel8 | ||
| prodtype: rhel6,rhel7 | ||
|
|
||
| title: 'Uninstall rsh Package' | ||
|
|
||
|
|
||
2 changes: 1 addition & 1 deletion
2
linux_os/guide/services/obsolete/r_services/service_rsh_disabled/rule.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...counts-physical/screen_locking/smart_card_login/install_smartcard_packages/bash/shared.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...nts/accounts-physical/screen_locking/smart_card_login/install_smartcard_packages/rule.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...accounts-physical/screen_locking/smart_card_login/smartcard_auth/anaconda/shared.anaconda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| # platform = multi_platform_rhel, multi_platform_ol | ||
| # platform = Red Hat Enterprise Linux 6,Red Hat Enterprise Linux 7,multi_platform_ol | ||
|
|
||
| package --add=pam_pkcs11 --add=esc |
2 changes: 1 addition & 1 deletion
2
.../accounts/accounts-physical/screen_locking/smart_card_login/smartcard_auth/bash/shared.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...system/accounts/accounts-physical/screen_locking/smart_card_login/smartcard_auth/rule.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ libreswan | |
| ntp | ||
| opensc | ||
| openssh-server | ||
| pcsc-lite | ||
| vsftpd | ||
| postfix | ||
| tmux | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have kept
ntphere because ruleservice_chronyd_or_ntpd_enabledrelies on check forpackage_ntp_installed.chronyd_or_ntpdrules need achronydonly rule version before ntp can be removed from this CSV.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could be achieved by JInja macros in the rule, OVALs and remediations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could filter out checks for
ntpand make it work, but the rule would still be calledchronyd_or_ntpd, which would be confusing...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can rename the rule to
clock_synchronization_enabled. But I agree with keepingntphere, it's easier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a ticket to break out these rules which should be separate rules and not rules joined by jinja.