Skip to content

Unselect rules for packages dropped in RHEL8#3742

Merged
redhatrises merged 2 commits intoComplianceAsCode:masterfrom
yuumasato:rhel8_drop_rules_dropped_packages_from_profile
Feb 10, 2019
Merged

Unselect rules for packages dropped in RHEL8#3742
redhatrises merged 2 commits intoComplianceAsCode:masterfrom
yuumasato:rhel8_drop_rules_dropped_packages_from_profile

Conversation

@yuumasato
Copy link
Copy Markdown
Member

@yuumasato yuumasato commented Feb 7, 2019

Description:

  • Do not select rules for packages dropped in RHEL8

Rationale:

  • According to Changes to packages page in Beta release notes, these packages won't be part of RHEL8.

@yuumasato yuumasato mentioned this pull request Feb 7, 2019
Closed
@yuumasato
Copy link
Copy Markdown
Member Author

yuumasato commented Feb 7, 2019

This PR does not drop packages from CSV files, it just unselects rules in profiles

@yuumasato yuumasato added this to the 0.1.43 milestone Feb 7, 2019
@yuumasato yuumasato changed the title Drop rules for packages dropped in RHEL8 Unselect rules for packages dropped in RHEL8 Feb 7, 2019
@matusmarhefka
Copy link
Copy Markdown
Member

matusmarhefka commented Feb 8, 2019

We can also remove the rule package_sendmail_removed from rhel8 ospp profile as the package is deprecated.

@yuumasato
Remove dropped packages rules from RHEL8 profiles
ad9445f
@yuumasato
Smartcards auth in RHEL8 should be done via sssd
00ff79b 
- pam_pkcs11 was removed from RHEL8
- piggy-backing fix: also enable pcsc-lite for Fedora
@yuumasato yuumasato force-pushed the rhel8_drop_rules_dropped_packages_from_profile branch from d9eb83d to 00ff79b Compare February 8, 2019 10:49
@scrutinizer-notifier
Copy link
Copy Markdown

scrutinizer-notifier commented Feb 8, 2019

The inspection completed: No new issues

@yuumasato
Copy link
Copy Markdown
Member Author

yuumasato commented Feb 8, 2019

We can also remove the rule package_sendmail_removed from rhel8 ospp profile as the package is deprecated.

Nice catch, fixed by brute force-push

@redhatrises redhatrises added the enhancement General enhancements to the project. label Feb 10, 2019
@redhatrises redhatrises self-assigned this Feb 10, 2019
@redhatrises
Copy link
Copy Markdown
Contributor

redhatrises commented Feb 10, 2019

Great job @yuumasato!

@redhatrises redhatrises merged commit f7e2fa9 into ComplianceAsCode:master Feb 10, 2019
@yuumasato yuumasato deleted the rhel8_drop_rules_dropped_packages_from_profile branch February 11, 2019 09:21
@yuumasato yuumasato mentioned this pull request Apr 1, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@redhatrises redhatrises

Labels

enhancement General enhancements to the project.

Projects

None yet

Milestone

0.1.43

Development

Successfully merging this pull request may close these issues.

4 participants

@yuumasato @matusmarhefka @scrutinizer-notifier @redhatrises