Rename group sap to sap_host#4332
Merged
yuumasato merged 1 commit intoComplianceAsCode:masterfrom May 7, 2019
Merged
Conversation
Workaround for OpenSCAP bug described in OpenSCAP/openscap#1325 The template cannot handle situation when a profile has a same name as some group. 'sap' group conflicts with 'sap' profile in OL7 content. These settings are not about configuring SAP itself but about configuring the underlying OS host, let's rename the group to sap_host.
|
The inspection completed: No new issues |
Member
|
LGTM. |
Collaborator
Author
|
So would be renaming the profile instead be better? I assume not because that would also break the tailoring |
Member
|
I believe that changing group ID has a smaller impact than changing profile ID. Ack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rename group sap to sap_host
Rationale:
Workaround for OpenSCAP bug described in OpenSCAP/openscap#1325
The template cannot handle situation when a profile has a same name as some group. 'sap' group conflicts with 'sap' profile in OL7 content. These settings are not about configuring SAP itself but about
configuring the underlying OS host, let's rename the group to sap_host. Another approach could be to rename the OL7 sap profile, but that could break some things for the users because they will have to start using the new ID and I have no idea about the way this profile is used by users.