Improve Bash code based on shellcheck feedback#4791
Merged
jan-cerny merged 1 commit intoComplianceAsCode:masterfrom Sep 4, 2019
Merged
Improve Bash code based on shellcheck feedback#4791jan-cerny merged 1 commit intoComplianceAsCode:masterfrom
jan-cerny merged 1 commit intoComplianceAsCode:masterfrom
Conversation
* Quote `find` glob, arguments, so they are protected from the shell.
* Quote the whole `awk` command, so shellcheck is not confused by unquoted curly braces.
* Fix a typo of `file_to_inspect` vs `files_to_inspect`.
* Made vars expansion explicit when they are followed by square brackets,
i.e. `$x[[:space:]]` to `${x}[[:space:]]`
* Separated `local` declarations from assignments using subsells.
`local` shadows the subshell return code in those cases.
* Removed `local` from the Jinja macro, as there is no function there.
* Changed `sed` separator in `FSTAB_TARGET_ROW` definition to `|`, got rid of `TARGET_ESCAPED`.
* Double-quoted backslashes in double quotes.
* Commented out unused def of `TARGET_OPTS`.
jan-cerny
changed the title
jan-cerny
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findglob arguments, so they are protected from the shell.awkcommand, so shellcheck is not confused by unquoted curly braces.file_to_inspectvsfiles_to_inspect.i.e.
$x[[:space:]]to${x}[[:space:]]localdeclarations from assignments using subsells.localshadows the subshell return code in those cases.localfrom the Jinja macro, as there is no function there.sedseparator inFSTAB_TARGET_ROWdefinition to|, got rid ofTARGET_ESCAPED.TARGET_OPTS.