Skip to content

Remove SCAP-1.3 SCAPVAL workarounds#6005

Merged
matejak merged 1 commit intoComplianceAsCode:masterfrom
yuumasato:test_update_scapval-1.3.5
Aug 17, 2020
Merged

Remove SCAP-1.3 SCAPVAL workarounds#6005
matejak merged 1 commit intoComplianceAsCode:masterfrom
yuumasato:test_update_scapval-1.3.5

Conversation

@yuumasato
Copy link
Copy Markdown
Member

Description:

  • These changes to the DS cause SRC-330 to fail in SCAPVAL-1.3.5.

Rationale:

  • In SCAPVAL-1.3.5 was fixed and these false positive workarounds are not
    necessary anymore.
  • Fixes SRC-330: FAIL in all DataStreams.

These changes to the DS cause SRC-330 to fail in SCAPVAL-1.3.5.
In SCAPVAL-1.3.5 was fixed and these false positive workarounds are not
necessary anymore.
@mildas
Copy link
Copy Markdown
Contributor

mildas commented Aug 17, 2020

Changes identified:
Others:
 Python abstract syntax tree change found in tests/run_scapval.py.

Recommended tests to execute:
 (cd build && cmake ../ && ctest -j4)

@yuumasato yuumasato requested a review from matejak August 17, 2020 09:06
@matejak matejak self-assigned this Aug 17, 2020
@matejak matejak added this to the 0.1.52 milestone Aug 17, 2020
@matejak
Copy link
Copy Markdown
Member

matejak commented Aug 17, 2020

FTR, this PR reverts a small part of #4327 that originally introduced run_scapval.py.

@matejak
Copy link
Copy Markdown
Member

matejak commented Aug 17, 2020

Merging, as I can confirm that our datastreams don't need this workaround in order to validate with scapval.

@matejak matejak merged commit d614226 into ComplianceAsCode:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants