Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions release_tools/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -149,18 +149,18 @@ Everything necessary for the release is built in Jenkins:
You can run `python3 release_content.py build` again to check status
of the jobs.
NOTE: As of July-20th 2019, it takes about 44 minutes for all the
builds finish.
builds to finish.

While Jenkins performs the builds you can generate and review the
release notes:

- Run `python3 release_content.py release_notes`

Format of the release notes are as follows:
Format of the release notes is as follows:
At the top Highlighted PRs will be listed, followed by list of product’s
profiles that changed since last release.
Followed by a list of *relevant* changes, genereated from the Pull
Requests mereged in this release.
Followed by a list of *relevant* changes, generated from the Pull
Requests merged in this release.
Not all PRs have an entry to avoid over cluttering. To determine the
*relevant* PRs a few heuristics are applied:

Expand All @@ -184,9 +184,9 @@ reviewed. We move on to creating the release entry in GitHub:

- Run `python3 release_content.py release`

It will create the next milestone (if it doens’t exist yet), move
It will create the next milestone (if it doesn’t exist yet), move
any open issues and PRs from current
milestone to next milesone, and close current release’s milestone.
milestone to next milestone, and close current release’s milestone.
The assets from Jenkins builds and the release notes will be used to
create the git release.
**Review the Git Release** and publish it.
Expand Down
5 changes: 3 additions & 2 deletions release_tools/content_gh.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,9 @@ def close_milestone(milestone):
def get_closed_prs(repo, milestone):
closed_issues = repo.get_issues(milestone=milestone, state="closed", sort="updated")
issues_with_prs = [i for i in closed_issues if i.pull_request is not None]
merged_prs =
[i.as_pull_request() for i in issues_with_prs if i.as_pull_request().merged is True]
merged_prs = [
i.as_pull_request() for i in issues_with_prs if i.as_pull_request().merged is True
]
return merged_prs


Expand Down