Handle long diffs gracefully in compare-ds github action#8041
Merged
matejak merged 1 commit intoComplianceAsCode:masterfrom Jan 10, 2022
Merged
Handle long diffs gracefully in compare-ds github action#8041matejak merged 1 commit intoComplianceAsCode:masterfrom
matejak merged 1 commit intoComplianceAsCode:masterfrom
Conversation
matejak
requested changes
Jan 10, 2022
Member
matejak
left a comment
matejak
left a comment
There was a problem hiding this comment.
The comments needs a typo fixed, otherwise LGTM!
| issue-number: ${{ github.event.pull_request.number }} | ||
| body: | | ||
| This datastream diff is auto generated by the check `Compare DS/Generate Diff`. | ||
| Due to the excessive size of the diff, it has been trimmed to fit the 4096-character limit. |
Member
There was a problem hiding this comment.
The limit is no longer 4096 characters.
It is probably based on 16-bit integer (0 to 65535), so setting the limit body to 65000 is sufficient - the surrounding text can't get longer that easily.
Initially I thought that 8000+ characters is too much, but I don't think so any more, the diff in the example PR is perfectly usable.
Member
Author
There was a problem hiding this comment.
Fixed by amending the commit. The limit is somehow connected to: actions/runner-images#3257 but I haven't really spend too much time investigating it. I believe the 65k chars is enough for our purposes.
ggbecker
force-pushed
the
limit-compare-ds-diff-size
branch
from
c469fc6 to
5177f7b
Compare
matejak
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Tested in ggbecker#26 (comment)
https://github.com/ggbecker/content/runs/4762507114?check_suite_focus=true
Co-authored with @matejak