Skip to content

Exclude user nfsnobody when checking home directories #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggbecker merged 2 commits into from
Mar 25, 2022
Merged

Exclude user nfsnobody when checking home directories #8426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beb0e07
Exclude user nfsnobody when checking home directories
mildas Mar 25, 2022
0370567
Define list of excluded users to check as shared variable
mildas Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions ...system/accounts/accounts-session/accounts_users_home_files_groupownership/oval/shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,18 @@
</definition>

<unix:password_object id="object_accounts_users_home_files_groupownership_objects" version="1">
<unix:username datatype="string" operation="not equal">nobody</unix:username>
<unix:username datatype="string" operation="pattern match">.*</unix:username>
<filter action="include">state_accounts_users_home_files_groupownership_interactive_gids</filter>
{{%- if product == 'rhel7' %}}
<filter action="exclude">state_accounts_users_home_files_groupownership_nfsnobody</filter>
{{%- endif %}}
<filter action="exclude">state_accounts_users_home_files_groupownership_user_list</filter>
</unix:password_object>

<unix:password_state id="state_accounts_users_home_files_groupownership_interactive_gids" version="1">
<unix:user_id datatype="int" operation="greater than or equal">{{{ gid_min }}}</unix:user_id>
</unix:password_state>

{{%- if product == 'rhel7' %}}
<unix:password_state id="state_accounts_users_home_files_groupownership_nfsnobody" version="1">
<unix:username datatype="string" operation="equals">nfsnobody</unix:username>
<unix:password_state id="state_accounts_users_home_files_groupownership_user_list" version="1">
<unix:username datatype="string" operation="pattern match">^{{{ user_list }}}$</unix:username>
</unix:password_state>
{{%- endif %}}

<local_variable id="var_accounts_users_home_files_groupownership_dirs" datatype="string" version="1"
comment="Variable including all home dirs from interactive users">
Expand Down
12 changes: 4 additions & 8 deletions ...uide/system/accounts/accounts-session/accounts_users_home_files_ownership/oval/shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,18 @@
</definition>

<unix:password_object id="object_accounts_users_home_files_ownership_objects" version="1">
<unix:username datatype="string" operation="not equal">nobody</unix:username>
<unix:username datatype="string" operation="pattern match">.*</unix:username>
<filter action="include">state_accounts_users_home_files_ownership_interactive_uids</filter>
{{%- if product == 'rhel7' %}}
<filter action="exclude">state_accounts_users_home_files_ownership_nfsnobody</filter>
{{%- endif %}}
<filter action="exclude">state_accounts_users_home_files_ownership_user_list</filter>
</unix:password_object>

<unix:password_state id="state_accounts_users_home_files_ownership_interactive_uids" version="1">
<unix:user_id datatype="int" operation="greater than or equal">{{{ uid_min }}}</unix:user_id>
</unix:password_state>

{{%- if product == 'rhel7' %}}
<unix:password_state id="state_accounts_users_home_files_ownership_nfsnobody" version="1">
<unix:username datatype="string" operation="equals">nfsnobody</unix:username>
<unix:password_state id="state_accounts_users_home_files_ownership_user_list" version="1">
<unix:username datatype="string" operation="pattern match">^{{{ user_list }}}$</unix:username>
</unix:password_state>
{{%- endif %}}

<local_variable id="var_accounts_users_home_files_ownership_dirs" datatype="string" version="1"
comment="Variable including all home dirs from interactive users">
Expand Down
12 changes: 4 additions & 8 deletions ...de/system/accounts/accounts-session/accounts_users_home_files_permissions/oval/shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,18 @@
<!-- For detailed comments about logic used in this OVAL, check the
"file_ownership_home_directories" rule. -->
<unix:password_object id="object_accounts_users_home_files_permissions_objects" version="1">
<unix:username datatype="string" operation="not equal">nobody</unix:username>
<unix:username datatype="string" operation="pattern match">.*</unix:username>
<filter action="include">state_accounts_users_home_files_permissions_interactive_uids</filter>
{{%- if product == 'rhel7' %}}
<filter action="exclude">state_accounts_users_home_files_permissions_nfsnobody</filter>
{{%- endif %}}
<filter action="exclude">state_accounts_users_home_files_permissions_user_list</filter>
</unix:password_object>

<unix:password_state id="state_accounts_users_home_files_permissions_interactive_uids" version="1">
<unix:user_id datatype="int" operation="greater than or equal">{{{ uid_min }}}</unix:user_id>
</unix:password_state>

{{%- if product == 'rhel7' %}}
<unix:password_state id="state_accounts_users_home_files_permissions_nfsnobody" version="1">
<unix:username datatype="string" operation="equals">nfsnobody</unix:username>
<unix:password_state id="state_accounts_users_home_files_permissions_user_list" version="1">
<unix:username datatype="string" operation="pattern match">^{{{ user_list }}}$</unix:username>
</unix:password_state>
{{%- endif %}}

<!-- #### prepare for test_file_permissions_home_directories #### -->
<local_variable id="var_accounts_users_home_files_permissions_dirs" datatype="string" version="1"
Expand Down
7 changes: 6 additions & 1 deletion ...ide/system/accounts/accounts-session/file_groupownership_home_directories/oval/shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,19 @@
<!-- For detailed comments about logic used in this OVAL, check the
"file_ownership_home_directories" rule. -->
<unix:password_object id="object_file_groupownership_home_directories_objects" version="1">
<unix:username datatype="string" operation="not equal">nobody</unix:username>
<unix:username datatype="string" operation="pattern match">.*</unix:username>
<filter action="include">state_file_groupownership_home_directories_interactive_gids</filter>
<filter action="exclude">state_file_permissions_groupownership_user_list</filter>
</unix:password_object>

<unix:password_state id="state_file_groupownership_home_directories_interactive_gids" version="1">
<unix:group_id datatype="int" operation="greater than or equal">{{{ gid_min }}}</unix:group_id>
</unix:password_state>

<unix:password_state id="state_file_permissions_groupownership_user_list" version="1">
<unix:username datatype="string" operation="pattern match">^{{{ user_list }}}$</unix:username>
</unix:password_state>

<!-- #### prepare for test_file_groupownership_home_directories #### -->
<local_variable id="var_file_groupownership_home_directories_dirs" datatype="string" version="1"
comment="Variable including all home dirs from primary interactive groups">
Expand Down
7 changes: 6 additions & 1 deletion ...os/guide/system/accounts/accounts-session/file_ownership_home_directories/oval/shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@
create local variables composed by UIDs e Home Dirs.
-->
<unix:password_object id="object_file_ownership_home_directories_objects" version="1">
<unix:username datatype="string" operation="not equal">nobody</unix:username>
<unix:username datatype="string" operation="pattern match">.*</unix:username>
<filter action="include">state_file_ownership_home_directories_interactive_uids</filter>
<filter action="exclude">state_file_ownership_home_directories_user_list</filter>
</unix:password_object>

<!--
Expand All @@ -34,6 +35,10 @@
<unix:user_id datatype="int" operation="greater than or equal">{{{ uid_min }}}</unix:user_id>
</unix:password_state>

<unix:password_state id="state_file_ownership_home_directories_user_list" version="1">
<unix:username datatype="string" operation="pattern match">^{{{ user_list }}}$</unix:username>
</unix:password_state>

<!--
#### prepare for test_file_groupownership_home_directories ####
From the list of interactive users objects we create a local variable composed of their home dirs.
Expand Down
7 changes: 6 additions & 1 deletion .../guide/system/accounts/accounts-session/file_permissions_home_directories/oval/shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,19 @@
<!-- For detailed comments about logic used in this OVAL, check the
"file_ownership_home_directories" rule. -->
<unix:password_object id="object_file_permissions_home_directories_objects" version="1">
<unix:username datatype="string" operation="not equal">nobody</unix:username>
<unix:username datatype="string" operation="pattern match">.*</unix:username>
<filter action="include">state_file_permissions_home_directories_interactive_uids</filter>
<filter action="exclude">state_file_permissions_home_files_permissions_user_list</filter>
</unix:password_object>

<unix:password_state id="state_file_permissions_home_directories_interactive_uids" version="1">
<unix:user_id datatype="int" operation="greater than or equal">{{{ uid_min }}}</unix:user_id>
</unix:password_state>

<unix:password_state id="state_file_permissions_home_files_permissions_user_list" version="1">
<unix:username datatype="string" operation="pattern match">^{{{ user_list }}}$</unix:username>
</unix:password_state>

<!-- #### prepare for test_file_permissions_home_directories #### -->
<local_variable id="var_file_permissions_home_directories_dirs" datatype="string" version="1"
comment="Variable including all home dirs from interactive users">
Expand Down
9 changes: 9 additions & 0 deletions shared/macros-oval.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,3 +902,12 @@
{{%- endif %}}
</def-group>
{{%- endmacro %}}

{{#
User list in form of regex that are excluded when checking user home directory permissions and ownerships.
#}}
{{%- if product in ["rhel7", "ol7"] %}}
{{%- set user_list="(nobody|nfsnobody)" %}}
{{%- else %}}
{{%- set user_list="nobody" %}}
{{%- endif %}}