Update grub2_uefi_password & grub2_uefi_admin_username#8438
Update grub2_uefi_password & grub2_uefi_admin_username#8438jan-cerny merged 5 commits intoComplianceAsCode:masterfrom
Conversation
DISA, in its STIG profile, requires this rule to verify only the user.cfg file. Also specifies a grub directory for grub2_uefi_boot_path Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
DISA, in its STIG profile, requires this rule to verify only the user.cfg file Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
This rule's OVAL was designed to pass if grub.cfg was missing, apparently to allow a scenario were grub is not installed. Remove that criterion from OVAL so that situation is managed by a CPE and remove test accordingly Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
This rule's OVAL was designed to pass if grub.cfg was missing, apparently to allow a scenario were grub is not installed. Remove that criterion from OVAL so that situation is managed by a CPE and remove test accordingly Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
|
Hi @Xeicker. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This datastream diff is auto generated by the check Click here to see the full diffOVAL definition oval:ssg-grub2_uefi_admin_username:def:1 differs:
--- old datastream
+++ new datastream
- criterion oval:ssg-test_grub2_uefi_admin_username_file_boot_efi_EFI_redhat_grub_cfg_absent:tst:1
OVAL definition oval:ssg-grub2_uefi_password:def:1 differs:
--- old datastream
+++ new datastream
- criterion oval:ssg-test_grub2_uefi_password_file_boot_efi_EFI_redhat_grub_cfg_absent:tst:1
- criteria AND
- criteria OR
- criterion oval:ssg-test_grub2_uefi_password_grubcfg:tst:1
- criterion oval:ssg-test_bootloader_uefi_superuser:tst:1 |
|
/ok-to-test |
Make previous changes which were only applicable to ol8 and rhel8, apply to all products Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
|
@Xeicker: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Remove `invalid_username.fail.sh` that configures an invalid GRUB user name. The reason is that starting from ComplianceAsCode#8438 the rule `grub2_uefi_password` no longer checks user names, it only checks passwords now, no an invalid user name can't make the rule fail.
Remove `invalid_username.fail.sh` that configures an invalid GRUB user name. The reason is that starting from ComplianceAsCode#8438 the rule `grub2_uefi_password` no longer checks user names, it only checks passwords now, no an invalid user name can't make the rule fail.
Description:
Rationale: