Skip to content

Can't run benchmarks as tests for integration-testsΒ #535

@seunlanlege

Description

@seunlanlege
composable on ξ‚  main [$!] is πŸ“¦ v1.0.9 via π—₯ v1.59.0 took 3m 41s
➜ cargo test --locked --workspace --features runtime-benchmarks --manifest-path Cargo.toml
   Compiling librocksdb-sys v6.20.3
   Compiling polkadot-runtime v0.9.13 (https://github.com/paritytech/polkadot?branch=release-v0.9.13#7d8f00b9)
   Compiling rococo-runtime v0.9.13 (https://github.com/paritytech/polkadot?branch=release-v0.9.13#7d8f00b9)
   Compiling dali-runtime v0.1.0 (/Users/seun/Projects/composable/runtime/dali)
   Compiling picasso-runtime v0.1.0 (/Users/seun/Projects/composable/runtime/picasso)
   Compiling composable-runtime v0.1.0 (/Users/seun/Projects/composable/runtime/composable)
   Compiling kusama-runtime v0.9.13 (https://github.com/paritytech/polkadot?branch=release-v0.9.13#7d8f00b9)
   Compiling orml-traits v0.4.1-dev (https://github.com/open-web3-stack/open-runtime-module-library?rev=17a791edf431d7d7aee1ea3dfaeeb7bc21944301#17a791ed)
   Compiling pallet-society v4.0.0-dev (https://github.com/composableFi/substrate?branch=polkadot-v0.9.13#375db2b9)
   Compiling bp-messages v0.1.0 (https://github.com/paritytech/polkadot?branch=release-v0.9.13#7d8f00b9)
error[E0046]: not all trait items implemented, missing: `successful_origin`
    --> /Users/seun/.cargo/git/checkouts/substrate-01ceebf642695c01/375db2b/frame/society/src/lib.rs:1264:1
     |
1264 | impl<T: Config> EnsureOrigin<T::Origin> for EnsureFounder<T> {
     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `successful_origin` in implementation
     |
     = help: implement the missing item: `fn successful_origin() -> OuterOrigin { todo!() }`

For more information about this error, try `rustc --explain E0046`.
error: could not compile `pallet-society` due to previous error
warning: build failed, waiting for other jobs to finish...

this command should run all tests, as well as benchmarks for every crate in the workspace. But there seems to be a dependency that is used in benchmarks, but doesn't have the runtime-benchmark feature turned on.
Our existing CI isn't complete without this step.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions