Conversation
|
Could someone check this (poke @seunlanlege @Br1ght0ne ) |
|
why not just add as dependency? |
|
@seunlanlege a notion page said to move it, could be simpler to just add is as a decencies to make the code base smaller, @scruffy-dev what do you think? |
|
less maintenance with linking it, but more customisation if its included |
runtime/picasso/Cargo.toml
Outdated
| timestamp = { package = "pallet-timestamp", git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.8", default-features = false } | ||
| transaction-payment = { package = "pallet-transaction-payment", git = "https://github.com/paritytech/substrate", branch = "polkadot-v0.9.8", default-features = false } | ||
| oracle = { package = "pallet-oracle", path = "../../frame/oracle", default-features = false } | ||
| utility = { package = "pallet-utility", path = "../../frame/utility", version = "0.1.0", default-features = false } |
There was a problem hiding this comment.
you should get this from the substrate folder like timestamp, or transaction payment. There is no need to pull it in manually. This would reduce code and would be a safer form of handling it
runtime/picasso/src/lib.rs
Outdated
| TransactionPayment: transaction_payment::{Pallet, Storage}, | ||
| Sudo: sudo::{Pallet, Call, Config<T>, Storage, Event<T>}, | ||
| Oracle: oracle::{Pallet, Call, Storage, Event<T>}, | ||
| Utility: utility::{Pallet, Call, Event<T>}, |
There was a problem hiding this comment.
I don't see the pallet config in here, does it compile?
There was a problem hiding this comment.
yeah, just tried it
There was a problem hiding this comment.
@flipchan please add the config
https://docs.rs/pallet-utility/3.0.0/pallet_utility/trait.Config.html
There was a problem hiding this comment.
plus, utility::Event isn't generic https://docs.rs/pallet-utility/3.0.0/pallet_utility/enum.Event.html
|
code updated now linked from upstream parity substrate |
|
@flipchan could you take a look at the CI failure? |
runtime/picasso/src/lib.rs
Outdated
| TransactionPayment: transaction_payment::{Pallet, Storage}, | ||
| Sudo: sudo::{Pallet, Call, Config<T>, Storage, Event<T>}, | ||
| Oracle: oracle::{Pallet, Call, Storage, Event<T>}, | ||
| Utility: utility::{Pallet, Call, Event<T>}, |
There was a problem hiding this comment.
@flipchan please add the config
https://docs.rs/pallet-utility/3.0.0/pallet_utility/trait.Config.html
|
added WeightInfo, need to add the Event : Event {
BatchInterrupted(u32, DispatchError),
BatchCompleted,
} |
|
adding event thing now |
|
@flipchan any blockers on getting this merged? |
|
Would be nice to get this merged, we still don't have a utility pallet. |
|
Hey, so sorry, missed this issue completely |
|
compiling here(with benchmarks): #68 |
chain agnostic client updates
4 participants
Add utility pallet to runtime