Skip to content

CU-1u5ykup - add generated types and refactor, add eth sign to crowdloan tests, bonded finance tests implementation #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hussein-aitlahcen merged 4 commits into from
Jan 18, 2022
Merged

CU-1u5ykup - add generated types and refactor, add eth sign to crowdloan tests, bonded finance tests implementation #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77cd64b
add generated types and refactor tests, add eth sign to crowdloan
hussein-aitlahcen Jan 13, 2022
6711986
Pulling bondPrice for bondedFinance Tests from variable
lilith-roth Jan 14, 2022
fdaf604
test(bondedFinance TX Tests, Added mocha config file, Cleanup.):
Jan 17, 2022
6081ffe
test(bondedFinance TX Tests, bondedFinance pallet, Runtime Tests Read…
Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frame/bonded-finance/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ pub mod pallet {
/// The minimum reward for an offer.
///
/// Must be > T::Vesting::MinVestedTransfer.
#[pallet::constant]
type MinReward: Get<BalanceOf<Self>>;

/// The origin that is allowed to cancel bond offers.
Expand Down Expand Up @@ -250,7 +251,7 @@ pub mod pallet {
&offer_account,
&issuer,
offer.reward.amount,
true,
false,
)?;
BondOffers::<T>::remove(offer_id);
Self::deposit_event(Event::<T>::OfferCancelled { offer_id });
Expand Down
12 changes: 12 additions & 0 deletions integration-tests/runtime-tests/.mocharc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"diff": true,
"extension": ["js", "cjs", "mjs"],
"package": "./package.json",
"reporter": "mochawesome",
"slow": "75",
"timeout": "2000",
"ui": "bdd",
"watch-files": ["lib/**/*.js", "test/**/*.js"],
"watch-ignore": ["lib/vendor"],
"require": "src/utils/testSetup.js"
}
8 changes: 7 additions & 1 deletion integration-tests/runtime-tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ $ npm run init
$ npm run test
```

### To run the type generator:
```bash
$ npm run gen
```


## ToDo:
* Add all general test cases.
Expand All @@ -43,7 +48,8 @@ Else the test will timeout before any results, causing a headache and wondering
e.g.
```typescript
describe('Imaginary Test', function () {
this.timeout(0); // <--
// Timeout set to 2 minutes
this.timeout(2*60*1000); // <--
it('Imaginary test part', async (done) => {
// Test Stuff...
});
Expand Down
Loading