This repository was archived by the owner on Feb 3, 2024. It is now read-only.
Add reporting and quote hiding#60
Merged
mxmeinhold merged 16 commits intoComputerScienceHouse:masterfrom Nov 17, 2021
Merged
Conversation
Collaborator
|
Upon a report, who would it go to? Is there a single email for this to go to or would it have to be sent to all individual RTP/Eboard emails? |
Contributor
Author
|
I believe eboard@ would work. I can check once power is back. |
Report Button allows quote to be sent to RTP/Eboard for review Hide prevents the quote from being seen by anyone except for speaker, submitter, and Eboard/RTPs Review is the process that Eboard/RTP view reported quotes to decide to keep or hide
jabbate19
force-pushed
the
reporting-and-hiding
branch
2 times, most recently
from
4eb6958 to
038b3f2
Compare
mxmeinhold
commented
Nov 10, 2021
Mstrodl
approved these changes
Nov 12, 2021
Member
Mstrodl
left a comment
Mstrodl
left a comment
There was a problem hiding this comment.
LGTM, look at my comments tho
Member
|
@jabbate19 can we get some screenshots?? |
Collaborator
|
I accidentally deleted my config.py with all the creds in it, so I can't really load anything to take screenshots |
WillNilges
approved these changes
Nov 12, 2021
Member
WillNilges
left a comment
WillNilges
left a comment
There was a problem hiding this comment.
LGTM. I have a few documentation-oriented things, but I didn't see anything egregious. 🙃
Collaborator
|
All corrections except for the pinning versions should be corrected as of 5685680 |
mxmeinhold
commented
Nov 12, 2021
Contributor
Author
mxmeinhold
left a comment
mxmeinhold
left a comment
There was a problem hiding this comment.
Please consider this to be requesting changes. I can't leave review statuses since this is my PR.
cc @Mstrodl @WillNilges please don't merge this
WillNilges
suggested changes
Nov 12, 2021
Member
WillNilges
left a comment
WillNilges
left a comment
There was a problem hiding this comment.
@jabbate19 Please look at and correct @mxmeinhold's comments.
mxmeinhold
commented
Nov 12, 2021
mxmeinhold
commented
Nov 12, 2021
mxmeinhold
commented
Nov 13, 2021
mxmeinhold
commented
Nov 15, 2021
mxmeinhold
commented
Nov 17, 2021
Collaborator
Pylint Caused Things to break Left a debug
Add Report Review Path Fix Docstring Wording for LDAP Documentation/Formatting Correction Wording and Error Handling Corrections
jabbate19
force-pushed
the
reporting-and-hiding
branch
from
9d89c6c to
a3cb5fb
Compare
WillNilges
approved these changes
Nov 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines database migrations, and adds report functionality and quote hiding.
Requirements:
Nice to have:
Resolves #58, resolves #47