Conversation
Member
|
Everything LGTM, @liam-middlebrook how should we go about merging this, given I'd like to test that everything is still operational. |
Contributor
Author
|
In the process of trying to test things I realized y'all made it impossible to bootstrap a new/testing install of gallery. I'll have another PR soon to address that and a few other issues |
Contributor
Author
|
I'm going to merge this tonight unless I hear otherwise, there are some fundamentally broken things that existed anyway that will be cleaned up in my second PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added mypy annotations to a majority of things. Unfortunately a lot of the 3rd party libraries don't have stubs so the coverage isn't great. It's a start though. I also fixed a bunch of pep8 violations and fixed things that mypy found. The biggest issue being the filtered view which seems to have been straight up broken in major ways.