Gallery Organizers#85
Conversation
|
For future reference, there's some wording (documented here) that you can use (vs just mentioning the issue number) that'll automatically close the issue once the associated PR is merged. i.e. you can edit the main description of this PR to say something like "Fixes #82" |
| app.config.get("EBOARD_UIDS", "").split(","), | ||
| app.config.get("RTP_UIDS", "").split(","), | ||
| app.config.get("ORGANIZER_UIDS", "").split(","), | ||
| app.config.get("ALUMNI_UIDS", "").split(","), |
There was a problem hiding this comment.
ALUMNI_UIDS doesn't seem to be used anywhere else in your PR, maybe remove it? Unless it's WIP
There was a problem hiding this comment.
This gets used by the ldap mock, which makes sense to me since alums have different privileges than active members.
That being said, are these documented/added to config samples?
There was a problem hiding this comment.
Ahh that makes sense, thanks. Doesn't look like it -- @jabbate19 could you add them to the config samples for clarity?
There was a problem hiding this comment.
Sounds good. I added because I realized there was nothing set up for ldap mock on alumni, so when I ran it in dev it failed bc it couldn't find the actual LDAP.
RamZallan
left a comment
RamZallan
left a comment
There was a problem hiding this comment.
Besides this + the config sample note, this all looks good to me! Has it been tested locally? (w/ the LDAP mock, I assume?)
| self._ldap = ldap | ||
| self._eboard: List[str] = [] | ||
| self._rtp: List[str] = [] | ||
| self._organzier: List[str] = [] |
|
Before I merge, @jabbate19 could you squash your commits into one? (HMU on Slack if you don't know how and I can help) |
Fix Gallery Organizers Fix Finalized Organizer Remove Files Re-add things I touched from dev Add to sample, fix spelling
3 participants
Fixes #82
Hacktober Pls :)