-
Notifications
You must be signed in to change notification settings - Fork 0
docs: include CDN information and links to examples #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
728a571
9e622b7
3f936b5
8f13afa
ef975be
a32cd3e
134e99c
209647c
ad01a61
91966da
036add9
542458c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,7 +93,7 @@ export type components = | |
| export interface BackgroundComponent extends BaseObject { | ||
| type: 'background'; | ||
| show?: boolean; // default: true | ||
| texture: string | TextureStyle; | ||
| texture: TextureStyle; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The type for If users were previously able to use a string here, this would be a breaking change. Could you clarify if this change is intentional and, if so, whether it's considered a breaking change? The README examples currently use the |
||
| } | ||
|
|
||
| /** | ||
|
|
@@ -102,10 +102,10 @@ export interface BackgroundComponent extends BaseObject { | |
| export interface BarComponent extends BaseObject { | ||
| type: 'bar'; | ||
| show?: boolean; // default: true | ||
| texture: string | TextureStyle; | ||
| texture: TextureStyle; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the Could you please confirm the intent behind this change and its potential impact? Ensuring consistency with how textures are defined is good, but we should be clear about any API contract changes. |
||
|
|
||
| placement?: Placement; // default: 'bottom' | ||
| margin?: string; // default: '0' | ||
| margin?: string; // default: '0', ('4 2', '2 1 3 4') | ||
| percentWidth?: number; // default: 1 (0~1) | ||
| percentHeight?: number; // default: 1 (0~1) | ||
| animation?: boolean; // default: true | ||
|
|
@@ -118,10 +118,10 @@ export interface BarComponent extends BaseObject { | |
| export interface IconComponent extends BaseObject { | ||
| type: 'icon'; | ||
| show?: boolean; // default: true | ||
| asset: string; | ||
| asset: string; // object, inverter, combiner, edge, device, loading, warning, wifi, etc. | ||
|
|
||
| placement?: Placement; // default: 'center' | ||
| margin?: string; // default: '0' | ||
| margin?: string; // default: '0', ('4 2', '2 1 3 4') | ||
| size: number; // 0 or higher | ||
| } | ||
|
|
||
|
|
@@ -133,7 +133,7 @@ export interface TextComponent extends BaseObject { | |
| show?: boolean; // default: true | ||
|
|
||
| placement?: Placement; // default: 'center' | ||
| margin?: string; // default: '0' | ||
| margin?: string; // default: '0', ('4 2', '2 1 3 4') | ||
| text?: string; // default: '' | ||
| style?: Record<string, unknown>; | ||
| split?: number; // default: 0 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there's an inconsistency in the icon component's property name here compared to the English
README.mdand theIconComponenttype definition insrc/display/data-schema/data.d.ts.The type definition specifies
asset: string;for icons, and the English README example usesasset: 'loading'. Usingtexture: 'loading'here might be misleading or incorrect based on the defined schema.Could you update this to use
assetfor consistency and correctness?