fix: clear animations on destroy call

[MinCrohn]

No description provided.

[gemini-code-assist]

Hello @MinCrohn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request. This PR addresses an issue where animations created using GSAP might not be properly cleaned up when the Patchmap instance is destroyed. This could potentially lead to resource leaks or unexpected behavior. The changes introduce the necessary steps to clear the global GSAP timeline during the destroy lifecycle method, ensuring that all active animations are stopped and removed.

Highlights

• Animation Cleanup Fix: The primary goal of this PR is to correctly handle the cleanup of GSAP animations when the Patchmap component is destroyed, preventing potential issues.
• GSAP Integration: The PR adds an import for the GSAP library and utilizes its global timeline cleanup functionality.

Changelog

• src/patchmap.js
  • Imported the gsap library.
  • Added gsap.globalTimeline.clear() call within the destroy() method to stop and clear all active GSAP animations upon instance destruction.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Animations run free,
Till destroy calls for cleanup,
Timeline now clear.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This PR addresses an important issue by ensuring GSAP animations are cleaned up when a Patchmap instance is destroyed. The addition of gsap.globalTimeline.clear() in the destroy method is a direct approach to this, and the necessary import for gsap has been correctly added. The change appears to align with existing patterns of GSAP usage within the codebase.

Summary of Findings

• Scope of GSAP Global Timeline Clearing: The use of gsap.globalTimeline.clear() in the destroy method effectively cleans up animations. It's worth confirming that this broad scope (clearing all animations on the global timeline) aligns with the application's overall GSAP strategy, especially considering potential interactions if other independent GSAP animations were to exist. The consistent use of this call in the draw method suggests this is likely the intended and established pattern.

Merge Readiness

This pull request introduces a valuable fix for animation cleanup in the Patchmap component. The primary change involves clearing the GSAP global timeline during the destroy phase, which is a direct and effective solution.

I've raised one point for clarification regarding the scope of gsap.globalTimeline.clear(), primarily to confirm that it aligns with the broader application architecture for GSAP animations. Given its consistent use elsewhere (e.g., in the draw method), it's highly probable that this is the intended behavior.

I recommend that the author confirm this point. Once confirmed, the PR should be in good shape for merging. As a reviewer, I am not authorized to approve pull requests; please ensure it undergoes any further necessary reviews and approvals according to your team's workflow.