fix: remove data reference in draw method call

[MinCrohn]

closed: #96

[gemini-code-assist]

Hello @MinCrohn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request to help everyone quickly understand the changes.

This PR, authored by MinCrohn, aims to address issue #96 by fixing how data is handled within the draw method. Specifically, it prevents the preprocessData function from potentially modifying the original data object passed into draw by creating a deep copy of the data before processing. Additionally, a debugging console log has been removed from a utility function.

Highlights

• Data Handling Fix: The primary change is in the draw method of the Patchmap class. The input data is now deep-copied using JSON.parse(JSON.stringify(data)) before being passed to preprocessData. This ensures that preprocessData operates on a copy and does not mutate the original data object provided to the draw method.
• Cleanup: A console.log statement that was outputting 'Transformed data output:' has been removed from the convertLegacyData utility function in src/utils/convert.js. This cleans up the console output.

Changelog

• src/patchmap.js
  • Deep-copied the input data object in the draw method before passing it to preprocessData to prevent mutation of the original data.
• src/utils/convert.js
  • Removed a debugging console.log statement from the convertLegacyData function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Data flows in,
A copy made, safe and sound,
No logs remain.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue by preventing the mutation of the input data object within the draw method by creating a deep copy. This is a good step towards ensuring data integrity. Additionally, a debugging console.log statement has been removed, which cleans up the codebase. My main feedback point revolves around the method chosen for deep cloning, which has some trade-offs to consider.

Summary of Findings

• Deep Cloning Method in draw(): The use of JSON.parse(JSON.stringify(data)) in src/patchmap.js for deep cloning effectively prevents mutation of the original data for JSON-compatible types. However, this method has performance implications for large datasets and limitations with certain data types (e.g., Date, RegExp, functions, undefined). It's important to ensure these limitations are acceptable for the expected use cases.
• Debug Log Removal: A console.log statement was removed from src/utils/convert.js. This is a good cleanup for production code. (No specific review comment added as this is a low-severity improvement and review settings focus on medium+).

Merge Readiness

The pull request makes a valuable fix by preventing unintended data mutation. The primary point of attention is the deep cloning strategy used in src/patchmap.js. While effective for many common scenarios, its performance and data type handling limitations should be acknowledged and deemed acceptable for this library's use cases.

I've marked this review with REQUEST_CHANGES to encourage a brief discussion or confirmation regarding these trade-offs. Once these considerations are acknowledged or addressed, the PR should be in a good state for merging. As an AI, I am not authorized to approve pull requests; please ensure further review and approval by team members.