Skip to content

fix: resolve link rendering error based on Relations rendering order #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MinCrohn merged 2 commits into from
Jul 16, 2025
Merged

fix: resolve link rendering error based on Relations rendering order #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a662fa
update trigger
MinCrohn Jul 16, 2025
0237c74
fix comment
MinCrohn Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/patchmap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,12 @@ class Patchmap {
event.removeAllEvent(this.viewport);
this.initSelectState();
draw(context, validatedData);

// Force a refresh of all relation elements after the initial draw. This ensures
// that all link targets exist in the scene graph before the relations
// attempt to draw their links.
this.update({ path: '$..children[?(@.type=="relations")]', refresh: true });

this.app.start();
return validatedData;

Expand Down
4 changes: 2 additions & 2 deletions src/utils/convert.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export const convertLegacyData = (data) => {
}
} else if (key === 'strings') {
objs[key].show = false;
objs[key].attrs = { zIndex: 20 };
for (const value of values) {
objs[key].children.push({
type: 'relations',
Expand Down Expand Up @@ -96,8 +97,7 @@ export const convertLegacyData = (data) => {
});
}
} else {
objs[key].attrs = {};
objs[key].attrs.zIndex = 10;
objs[key].attrs = { zIndex: 10 };
for (const value of values) {
const { transform, ...props } = value.properties;
objs[key].children.push({
Expand Down