Skip to content

Conversation

@MinCrohn
Copy link
Collaborator

There was an issue where the label property was unintentionally deleted because it was treated as undefined if not included in the changes object when the update method was executed.

In the _applyRaw method, label is now handled as an exception, similar to id, to prevent it from being deleted. This prevents the unexpected loss of the object's label property.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @MinCrohn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific bug where the label property of an object could be inadvertently removed during an update operation. The core change involves modifying the internal _applyRaw method to ensure that label is treated as a protected property, preventing its deletion when it's not explicitly provided in the update payload, thus maintaining data integrity.

Highlights

  • Bug Fix: Resolved an issue where the label property was unintentionally deleted during object updates when its value was implicitly undefined in the update payload.
  • Core Logic Update: Updated the _applyRaw method in src/display/mixins/Base.js to prevent the deletion of the label property, similar to how the id property is handled, by explicitly excluding it from the deletion logic when its value is undefined.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue where the label property could be unintentionally deleted during an update. The fix prevents the deletion of the label property if it's not provided in the update payload, similar to how the id property is handled.

@MinCrohn MinCrohn merged commit 6be7d5b into v0.3.x Jul 24, 2025
@MinCrohn MinCrohn deleted the bugfix/delete-label-bug branch July 24, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants