Skip to content

Conversation

@MinCrohn
Copy link
Collaborator

You can now import and use the selector utility directly from the library.

@gemini-code-assist
Copy link

Summary of Changes

Hello @MinCrohn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a minor but impactful change by exporting the selector utility directly from the library. This modification streamlines the process for developers to access and use this utility, improving the overall developer experience and making the library's functionality more readily available.

Highlights

  • Utility Export: The selector utility is now directly exported from the library's main entry point.
  • Accessibility: Users can now import and utilize the selector utility directly, simplifying its usage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exports the selector utility to make it available to library consumers. The implementation is functional, but it introduces an inconsistency in the project's export patterns. My review includes a comment on how to improve this for better code maintainability by aligning it with how other utilities are exported.

export { Command } from './command/commands/base';
export { default as Transformer } from './transformer/Transformer';
export { default as State, PROPAGATE_EVENT } from './events/states/State';
export { selector } from './utils/selector/selector';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with how other utilities are exported, it would be better to add the selector export to src/utils/index.js. This file (src/patch-map.ts) already has export * from './utils', which would then automatically export selector. This approach centralizes all utility exports in one place and keeps this top-level export file cleaner and focused on major components.

@MinCrohn MinCrohn merged commit 0a43ea0 into main Oct 17, 2025
@MinCrohn MinCrohn deleted the chore/export-selector branch October 17, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants