fix: update legacy data conversion

[MinCrohn]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @MinCrohn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial fix to the legacy data conversion process. It standardizes the assignment of a display attribute to various converted entities, such as panel groups, panels, combines, inputs, and outputs. This ensures that these elements are correctly identified and categorized after conversion, which is vital for their subsequent rendering and functional handling within the application.

Highlights

• Enhanced Legacy Data Conversion: The convertLegacyData utility has been updated to include a new display attribute for various converted entities, ensuring proper categorization.
• Specific Display Assignments for Panel Groups: Converted panelGroup items now explicitly receive display: 'panelGroup'.
• Dynamic Display Assignments for Panels: Converted panel items now have their display attribute set dynamically based on their key (e.g., key.slice(0, -1)).
• Conditional Display for Combines, Inputs, and Outputs: Converted combines items are assigned display: 'combiner', while inputs and outputs receive a display value derived from their key (e.g., key.slice(0, -1)).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a display property to objects during legacy data conversion. I have two points of feedback. First, there's an inconsistency in how the display value is determined for 'grids' compared to other types, which might be a bug. Second, I've noticed some code duplication where the same logic is used in two different places, and I've suggested a small refactoring to improve maintainability.

[gemini-code-assist]

The display property is set to 'panelGroup'. In other parts of this function (for strings and other types), the display value is derived from the key by removing the trailing 's' (e.g., 'strings' becomes 'string'). For consistency, should this be 'grid' instead, which would be key.slice(0, -1) and also matches the element type on line 25? If 'panelGroup' is intentional, consider adding a comment to explain why this case is different.

[gemini-code-assist]

The logic to determine the display type, key === 'combines' ? 'combiner' : key.slice(0, -1), is also used on line 123 for the icon source. This creates duplication. To improve maintainability, you could define a variable at the start of the for loop (around line 104) and reuse it in both places.

For example:

const displayType = key === 'combines' ? 'combiner' : key.slice(0, -1);

Then use displayType for both source and display.