fix: prevent drag selection when config.draggable is false

[MinCrohn]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @MinCrohn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where drag selection could still occur even when the draggable configuration was set to false. The changes ensure that the drag selection mechanism correctly respects the draggable setting, providing more precise control over user interactions and preventing unintended behavior.

Highlights

• Prevent unwanted drag selection: Modified the onpointermove handler to immediately return if config.draggable is false, effectively stopping any drag-related movement when dragging is disabled.
• Conditional drag selection on pointer up: Updated the onpointerup handler to only execute the dragSelect logic if config.draggable is true, ensuring that selection via dragging is explicitly controlled by the configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly prevents drag selection when config.draggable is set to false by adding checks in the event handlers. The logic in onpointermove is sound and effectively stops drag operations from initiating. I've added one suggestion in onpointerup to remove a redundant condition, which will improve code clarity without affecting the functionality.

[MinCrohn]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly prevents drag selection when config.draggable is set to false by adding an early return in the onpointermove event handler. The logic is sound and directly addresses the issue described. I have one minor suggestion to improve code style and maintainability.

[MinCrohn]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly prevents drag selection when config.draggable is set to false by adding a check in the onpointermove event handler. The change is simple and effective. However, my review identified a related bug where a single click (or a drag action when dragging is disabled) results in the onSelect callback being fired twice. I've added a comment with details on this issue and a recommendation for a fix, which involves a change outside the current diff.