fix: add viewport setter

[MinCrohn]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @MinCrohn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Patchmap class by adding a public setter for its viewport property. This change improves the class's encapsulation by providing a designated method for updating the viewport, centralizing any associated logic. The class's initialization and destruction routines have been refactored to leverage this new setter, ensuring consistent and controlled management of the viewport throughout its lifecycle.

Highlights

• Viewport Setter Added: A new set viewport(value) accessor has been introduced to the Patchmap class, allowing controlled modification of the internal _viewport property.
• Encapsulation Improvement: The init and destroy methods within the Patchmap class have been updated to utilize the newly added viewport setter, promoting better encapsulation by routing viewport assignments through the public setter rather than direct private property access.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a setter for the viewport property and updates its usage throughout the class. While this is a good step towards better encapsulation, the current implementation of the setter can lead to memory leaks and unexpected behavior. I've provided a suggestion to make the setter more robust by ensuring the old viewport is properly destroyed and cleaned up before a new one is assigned. This change is important for the stability and predictability of the Patchmap component.