fix: resolve race condition in concurrent initAsset calls

[MinCrohn]

closed: #137

[gemini-code-assist]

Summary of Changes

Hello @MinCrohn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical race condition within the initAsset function, which previously led to unpredictable behavior when multiple parts of the application tried to initialize the same assets or bundles simultaneously. The updated logic ensures that asset and bundle additions and loadings are handled in an idempotent manner, guaranteeing consistent state and preventing redundant operations, thereby improving the stability and reliability of asset initialization.

Highlights

• Race Condition Resolution: Addressed a race condition in the initAsset function that could occur when multiple concurrent calls attempted to initialize the same assets or bundles.
• Improved Asset Management Logic: Refactored the asset and bundle collection process to use Maps and Sets, ensuring that assets are added and loaded uniquely and idempotently across concurrent invocations.
• Robust PIXI.Assets API Usage: Enhanced the use of PIXI.Assets API methods like addBundle, add, loadBundle, and load to handle concurrent operations more reliably.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a race condition in concurrent calls to initAsset. The approach of separating asset collection from asset registration and loading is a good step forward. The logic has been improved by using Map and Set for better handling of asset definitions and by using the correct PIXI.Assets.resolver.hasKey method. However, the fix is incomplete as a race condition still exists between checking for an asset's existence and adding it. My review includes a critical comment with a suggested code change to fully resolve this issue by using try...catch blocks, making the asset registration process robust against concurrency.