fix: enable update method to target viewport

[MinCrohn]

Usage

// Example: Updating viewport properties
patchmap.update({
  path: '$', // Assuming '$' or specific selector targets the viewport
  changes: {
    // ... viewport specific attributes
  }
});

Developer

• Renamed the internal update method to apply to avoid overriding the native update method in pixi-viewport's Viewport class.

[gemini-code-assist]

Summary of Changes

Hello @MinCrohn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily addresses a naming conflict by renaming the internal update method to apply, which also extends the capability to modify viewport properties directly. Alongside this core change, the PR includes significant updates to the development environment, particularly around linting and dependency management, to improve code quality and maintainability.

Highlights

• Refactored Update Method: The internal update method across various display components and mixins has been renamed to apply to prevent conflicts with the native update method of pixi-viewport.
• Viewport Targetability: The apply method can now directly target and update properties of the viewport itself, enhancing control over the display area.
• Linting Tooling Update: The project's linting setup has been modernized by integrating lint-staged and biome, replacing a custom pre-commit hook and updating related dependencies.
• Dependency Management: Numerous development dependencies in package-lock.json have been updated, and peer: true has been removed from several entries, streamlining dependency resolution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a well-executed refactoring that renames the update method to apply throughout the codebase. This change, aimed at preventing a name collision with pixi-viewport, is consistently applied across all relevant components, elements, and mixins. The introduction of a BaseViewport class is a clean solution to enable this for the viewport itself. Additionally, the PR brings several valuable improvements, including modernizing Object.prototype.hasOwnProperty.call to Object.hasOwn, and enhancing the development workflow by integrating lint-staged with a pre-commit hook. My review includes one suggestion to further refine the code structure by moving the logic that adds the viewport to the shared context out of the BaseViewport constructor, which would improve separation of concerns.

[MinCrohn]

/gemini review

[gemini-code-assist]

Code Review

This pull request primarily refactors the display update mechanism and integrates lint-staged for improved code quality. The update method across various display components and mixins has been consistently renamed to apply, centralizing viewport logic within a new BaseViewport class that leverages Base and Childrenable mixins and validates changes against a canvasSchema. The initViewport function now accepts a context parameter, establishing a crucial bidirectional link between the viewport and the application context. For linting, the .husky/pre-commit hook was simplified to use npx lint-staged, which was added as a new dev dependency and configured to run biome check --write --no-errors-on-unmatched on relevant files. The biome.json configuration was updated to disable the useIterableCallbackReturn rule, a change the reviewer noted should be double-checked for potential logic issues. Additionally, package-lock.json was updated to reflect the new lint-staged dependency and removed peer: true flags from several packages, while Object.prototype.hasOwnProperty.call was replaced with Object.hasOwn for modernization, and a fit function import was aliased to fitViewport to avoid naming conflicts.