Skip to content

fix: prevent infinite growth of links in relations #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MinCrohn merged 1 commit into from
Dec 16, 2025
Merged

fix: prevent infinite growth of links in relations #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/display/elements/Relations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { Graphics } from 'pixi.js';
import { calcOrientedBounds } from '../../utils/bounds';
import { relationsSchema } from '../data-schema/element-schema';
import { Relationstyleable } from '../mixins/Relationstyleable';
import { Linksable } from '../mixins/linksable';
import { Relationstyleable } from '../mixins/Relationstyleable';
import { mixins } from '../mixins/utils';
import Element from './Element';

Expand All @@ -21,7 +21,10 @@ export class Relations extends ComposedRelations {
}

update(changes, options) {
super.update(changes, relationsSchema, options);
super.update(changes, relationsSchema, {
...options,
mergeStrategy: 'replace',
});
}
Comment on lines 23 to 28
Copy link

@gemini-code-assist gemini-code-assist bot Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While this change to use mergeStrategy: 'replace' correctly fixes the issue of the links array growing on each update, it introduces two significant problems:

  1. Broken Style Updates: This change causes a side effect where partial style updates no longer work. The _applyRelationstyle handler also uses mergeStrategy. With 'replace', it will replace the entire style on the underlying graphics object, instead of merging. For instance, updating just the width of a link will cause its color to be reset. This is a critical bug.

  2. Failing Tests: This change alters the behavior of links updates from merging to replacement. However, the existing tests in src/tests/render/Relations.test.js and src/tests/undo-redo/Relations.test.js still expect the old merging behavior (e.g., expect(updatedLinks.length).toBe(2)). These tests will now fail and need to be updated to reflect the new intended behavior.

A more targeted fix is needed. One approach is to refactor _applyRelationstyle to not depend on mergeStrategy. Alternatively, you could explore ways to apply the replace strategy only to the links array without affecting other properties during the update process.

Please address the style update bug and update the relevant tests.


initPath() {
Expand Down