fix: handle destroyed elements safely in commands and animations

[MinCrohn]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @MinCrohn, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the stability and maintainability of the application's display system. It addresses potential issues arising from operations on destroyed elements by introducing robust element resolution logic and checks within commands and animations. Furthermore, it standardizes the element update mechanism by refactoring to a unified apply method, making the codebase more consistent and easier to reason about. The introduction of a custom BaseViewport also provides a more integrated and extensible foundation for the main display area.

Highlights

• Robust Element Handling: Implemented safe checks for destroyed elements within commands and animations. The UpdateCommand now includes a _resolveElement method to locate elements even if their direct reference is stale, searching through parent containers and the viewport. Animation tweens also now check if an element is destroyed before attempting updates.
• Standardized Element Updates: Refactored the update method across all display elements and mixins to a new apply method. This change standardizes how properties are applied to elements, improving consistency and maintainability throughout the display system.
• Custom Viewport Integration: Introduced a new BaseViewport class, which extends pixi-viewport and integrates custom mixins. This allows for more controlled and consistent handling of the main canvas element, including its children and property application via the new apply method.
• Linting Workflow Improvement: Integrated lint-staged into the pre-commit hook, replacing the previous manual linting script. This ensures that only staged .js, .ts, and .svelte files are linted and formatted using biome check --write before commits, streamlining the development workflow.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request provides a crucial fix for handling destroyed elements within commands and animations, significantly improving the robustness of the library. The new _resolveElement logic in UpdateCommand is well-designed for re-finding elements that may have been recreated. The addition of a destroyed check within the animation loop is an excellent safeguard against potential runtime errors.

I'm also impressed with the broader refactoring efforts. Renaming update to apply across the codebase brings great consistency. The introduction of a dedicated BaseViewport class and the simplification of the draw function are clean and maintainable improvements. The adoption of lint-staged and modern JavaScript features like Object.hasOwn are also positive steps.

I have a couple of minor suggestions to enhance code clarity and safety in the mixins. Overall, this is a high-quality contribution.

[MinCrohn]

/gemini review