-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add inactiveCellStrategy to Grid to support hiding inactive cells #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @MinCrohn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Grid component by introducing a configurable Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a inactiveCellStrategy to the Grid component, which is a great feature for optimizing performance in dynamic grids. The implementation is mostly solid, adding the new 'hide' strategy while keeping 'destroy' as the default. The changes in the data schema and the core logic in Cellsable.js correctly reflect this new option. I have one suggestion regarding a subtle change in behavior for how item labels are generated from cell values, which might be an unintended side effect.
Summary
This PR introduces the
inactiveCellStrategyoption to the Grid component, allowing users to choose how inactive cells (0 or empty values) are handled. This provides more flexibility between memory optimization and UI responsiveness.✨ Key Features
Previously, items in the grid were automatically destroyed when their cell value became
0. Now, users can toggle between two strategies:destroy(Default): Completely removes the item from the grid.hide: Keeps the item in the grid but masks it from view.🛠 Usage Example
🔍 Changes
inactiveCellStrategyproperty to the Grid component (Default:'destroy').data.d.ts.💡 Why is this needed?
In "grid-scale" UIs where users frequently toggle statuses, destroying and recreating DOM/canvas elements can cause performance stutters. The
hidestrategy allows for near-instant state transitions by keeping the components initialized.