Add world rotation/flip support

[kujung-conalog]

• Add world container and view-state transforms.
• Keep text/icon readable under flips.
• Update focus/fit and relations for world coords.

[gemini-code-assist]

Summary of Changes

Hello @kujung-conalog, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the display system by introducing robust support for world-level transformations, specifically rotation and flipping. It achieves this by encapsulating all display elements within a new World container, allowing global transformations to be applied uniformly. Crucially, it ensures that interactive elements like text and icons remain correctly oriented and readable, and updates the viewport's focus and fit functionalities to seamlessly integrate with these new transformation capabilities.

Highlights

• New World Container: Introduced a new World container (src/display/World.js) that acts as a central parent for all display elements, enabling global transformations like rotation and flipping.
• World Rotation and Flip API: Added new methods to the Patchmap class (src/patchmap.js) for controlling world rotation (setRotation, rotateBy, resetRotation) and flipping (setFlip, toggleFlipX, toggleFlipY, resetFlip).
• Text and Icon Readability: Implemented logic in Icon.js and Text.js to automatically adjust their scale and position (_applyWorldFlip method using src/display/utils/world-flip.js) to maintain readability when the world is flipped.
• Updated Focus and Fit Logic: Modified the focus-fit.js module to correctly calculate and apply viewport centering and fitting (moveViewportCenter from src/utils/viewport-rotation.js) in the presence of world rotations and flips.
• Coordinate System Adjustments: Adjusted coordinate transformations in Relations.js to use the local coordinate system of the new World container, ensuring correct positioning after global transformations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for world rotation and flipping by adding a World container within the viewport. This is a solid architectural change that isolates global transformations from the viewport itself. The changes also thoughtfully update text and icon elements to remain readable when the world is flipped, and adjust focus/fit logic to work correctly with the new transformed coordinates. My review includes a few suggestions for improvement: a critical bug fix for the flip logic, a refactoring for efficiency, and another for code clarity and performance.