Skip to content

fix stack overflow on getMessage #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thmarx merged 1 commit into from
Dec 13, 2024
Merged

fix stack overflow on getMessage #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cms-templates/src/main/java/com/condation/cms/templates/exceptions/ParserException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ public ParserException(String message, int line, int column) {

@Override
public String getLocalizedMessage() {
return "Error: %s (line %d, column %d)".formatted(getMessage(), line, column);
return "Error: %s (line %d, column %d)".formatted(super.getMessage(), line, column);
}

@Override
public String getMessage() {
return "Error: %s (line %d, column %d)".formatted(getMessage(), line, column);
return getLocalizedMessage();
}
}
4 changes: 2 additions & 2 deletions cms-templates/src/main/java/com/condation/cms/templates/exceptions/RenderException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@ public RenderException(String message, int line, int column) {

@Override
public String getLocalizedMessage() {
return "Error: %s (line %d, column %d)".formatted(getMessage(), line, column);
return "Error: %s (line %d, column %d)".formatted(super.getMessage(), line, column);
}

@Override
public String getMessage() {
return "Error: %s (line %d, column %d)".formatted(getMessage(), line, column);
return getLocalizedMessage();
}

}
4 changes: 2 additions & 2 deletions cms-templates/src/main/java/com/condation/cms/templates/exceptions/TagException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ public TagException(String message, int line, int column) {

@Override
public String getLocalizedMessage() {
return "Error: %s (line %d, column %d)".formatted(getMessage(), line, column);
return "Error: %s (line %d, column %d)".formatted(super.getMessage(), line, column);
}
@Override
public String getMessage() {
return "Error: %s (line %d, column %d)".formatted(getMessage(), line, column);
return getLocalizedMessage();
}
}
4 changes: 2 additions & 2 deletions ...lates/src/main/java/com/condation/cms/templates/exceptions/TemplateNotFoundException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ public TemplateNotFoundException(String message) {

@Override
public String getLocalizedMessage() {
return "Error: %s".formatted(getMessage());
return "Error: %s".formatted(super.getMessage());
}

@Override
public String getMessage() {
return "Error: %s".formatted(getMessage());
return getLocalizedMessage();
}
}
4 changes: 2 additions & 2 deletions cms-templates/src/main/java/com/condation/cms/templates/exceptions/UnknownTagException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ public UnknownTagException(String message, int line, int column) {

@Override
public String getLocalizedMessage() {
return "Error: %s (line %d, column %d)".formatted(getMessage(), line, column);
return "Error: %s (line %d, column %d)".formatted(super.getMessage(), line, column);
}

@Override
public String getMessage() {
return "Error: %s (line %d, column %d)".formatted(getMessage(), line, column);
return getLocalizedMessage();
}
}