Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions spec/src/modules/browse.js
Original file line number Diff line number Diff line change
Expand Up @@ -1057,6 +1057,51 @@ describe(`ConstructorIO - Browse${bundledDescriptionSuffix}`, () => {
});
});

it('Should return a return a response with pre filter expression properly parsed', (done) => {
const preFilterExpression = {
or: [
{
and: [
{
name: 'group_id',
value: 'electronics-group-id',
},
{
name: 'Price',
range: ['-inf', 200],
},
],
},
{
and: [
{
name: 'Type',
value: 'Laptop',
},
{
not: {
name: 'Price',
range: [800, 'inf'],
},
},
],
},
],
};
const { browse } = new ConstructorIO({
apiKey: testApiKey,
fetch: fetchSpy,
});

browse.getBrowseResultsForItemIds(ids, { preFilterExpression }).then((res) => {
expect(res).to.have.property('request').to.be.an('object');
expect(res).to.have.property('response').to.be.an('object');
expect(res).to.have.property('result_id').to.be.an('string');
expect(JSON.stringify(res.request.pre_filter_expression)).to.equal(JSON.stringify(preFilterExpression));
done();
});
});

it('Should emit an event with response data', (done) => {
const { browse } = new ConstructorIO({
apiKey: testApiKey,
Expand Down
1 change: 1 addition & 0 deletions src/modules/browse.js
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ class Browse {
* @param {string[]} [parameters.hiddenFields] - Hidden metadata fields to return
* @param {string[]} [parameters.hiddenFacets] - Hidden facets to return
* @param {object} [parameters.variationsMap] - The variations map object to aggregate variations. Please refer to https://docs.constructor.com/reference/shared-variations-mapping for details
* @param {object} [parameters.preFilterExpression] - Faceting expression to scope browse results. Please refer to https://docs.constructor.com/reference/configuration-collections
* @param {object} [networkParameters] - Parameters relevant to the network request
* @param {number} [networkParameters.timeout] - Request timeout (in milliseconds)
* @returns {Promise}
Expand Down
2 changes: 1 addition & 1 deletion src/types/browse.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ declare class Browse {

getBrowseResultsForItemIds(
itemIds: string[],
parameters?: Omit<IBrowseParameters, 'preFilterExpression' | 'qsParam'>,
parameters?: Omit<IBrowseParameters, 'qsParam'>,
networkParameters?: NetworkParameters
): Promise<GetBrowseResultsForItemIdsResponse>;

Expand Down
Loading