Skip to content

Conversation

@mocca102
Copy link
Contributor

@mocca102 mocca102 commented Jul 1, 2025

No description provided.

@mocca102 mocca102 requested review from a team and Copilot July 1, 2025 13:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a GitHub Actions pipeline to publish the built JavaScript SDK to an S3-backed CDN whenever a new version tag is pushed or manually triggered.

  • Introduces a top-level workflow (publish.yml) to kick off deployments on v* tag pushes and via manual dispatch.
  • Provides a reusable workflow (publish-cdn.yml) that checks out code, configures AWS OIDC creds, syncs versioned files to S3, and notifies Slack.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/publish.yml Defines trigger on tag pushes and manual dispatch; calls the CDN workflow
.github/workflows/publish-cdn.yml Implements checkout, AWS credential setup, file copy/sync to S3, and Slack notification
Comments suppressed due to low confidence (3)

.github/workflows/publish-cdn.yml:18

  • A build step (e.g., installing dependencies and running the build) is missing before copying the dist/ files; without this, the dist/ directory may not exist. Consider adding something like:
- name: Install and build
  run: |
    npm ci
    npm run build
      - uses: actions/checkout@v4

.github/workflows/publish-cdn.yml:1

  • [nitpick] The workflow name repeats the word "Publish". Consider simplifying to name: 'Publish to CDN' for clarity and brevity.
name: 'Publish: Publish to CDN'

.github/workflows/publish.yml:5

  • [nitpick] Using tags: ['v*'] matches any tag starting with v. If you intend to deploy only semantic versions, you could use a more precise pattern like v*.*.* to avoid unintended triggers.
    tags: ['v*']

Copy link

@madeel20 madeel20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocca102 mocca102 merged commit 68a81ac into master Jul 15, 2025
7 of 8 checks passed
@mocca102 mocca102 deleted the ci-4185-client-javascript-host-a-bundled-version-of-the-sdk-via-a branch July 15, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants