Improve typings for IdOptions #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the code and tests in https://github.com/Constructor-io/constructorio-identity/ it seemed like these were the supported values. Current code also allows you to specify any string, for example
'none'. Looking at the code, it looks like in that case it would not use any storage at all and instead generate a new id for the user every time the library is initialized. This however does not seem like a supported option (or even desirable, except maybe for testing) and would work only because the code does not do validation on the provided parameters.Ideally these typings should also rather be part of the constructorio-identity project and not in constructorio-client-javascript.