[CSL-2831] Add filter_by to variations map #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esezen
approved these changes
Sep 29, 2023
Contributor
esezen
left a comment
esezen
left a comment
There was a problem hiding this comment.
LGTM! filterBy is very complex so taking in a JSON string might be the way to go (current implementation). @jjl014 wdyt?
Probably not related to this PR but mvn wasn't working for me with the error Target option 7 is no longer supported. Use 8 or later.. I had to change source and target to 8.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.0</version>
<configuration>
<source>8</source>
<target>8</target>
</configuration>
</plugin>
jjl014
approved these changes
Sep 29, 2023
Contributor
jjl014
left a comment
jjl014
left a comment
There was a problem hiding this comment.
Nice, this looks great to me as well! 🚀
@esezen I was able to run the tests while still on version 7. I changed it to 8 as well and ran mvn install with no issues. We can update it to version 8 in a separate PR so it's consistent for everyone. 👍
stanlp1
deleted the
csl-2831-java-sdk-add-support-for-filter_by-in-variations-mapping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.