[CI-3556] Add Path List to ResultGroup Object #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mudaafi
requested review from
a team and
stanlp1
and removed request for
a team and
stanlp1
stanlp1
approved these changes
Jun 7, 2024
Contributor
stanlp1
left a comment
stanlp1
left a comment
There was a problem hiding this comment.
LGTM Thanks for adding this.
Super minor comments.
|
|
||
| import com.google.gson.annotations.SerializedName; | ||
|
|
||
| /** Constructor.io Item Group ... uses Gson/Reflection to load data in */ |
| private String path; | ||
|
|
||
| @SerializedName("path_list") | ||
| private List<ResultGroupPathListItem> pathList; |
Contributor
There was a problem hiding this comment.
wyt about just naming this PathListItem or PathListGroup.. Something like that.
No harm, it's fine as is but just thought it was long 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add
path_listtoResultGroupmodel.Changes
ResultGroupPathListItemResultGroupNote
Version_Id for Quizzes seems incorrect for the tests. I'll throw up a story to fix it.